Date: Fri, 18 Jan 2013 03:34:37 +0100
From: Andres Freund <andres@2ndquadrant.com>
To: Craig Ringer <craig@2ndQuadrant.com>
Cc: Dimitri Fontaine <dimitri@2ndQuadrant.fr>, Tom Lane <tgl@sss.pgh.pa.us>,
	Simon Riggs <simon@2ndQuadrant.com>, Robert Haas <robertmhaas@gmail.com>,
	Alvaro Herrera <alvherre@2ndQuadrant.com>,
	PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Subject: Re: Event Triggers: adding information
Message-ID: <20130118023437.GH3074@awork2.anarazel.de>
References: 
 <CA+TgmobfeB_YpgMv5NjW52tG36Hg_DY=jq0XDkE5zwCstPQ4pg@mail.gmail.com>
	<m2pq14m7sx.fsf@2ndQuadrant.fr>
	<CA+TgmoYEW583z+oisToCYQMz2grzpavdXrCi3-W2D_+nucVhzQ@mail.gmail.com>
	<CA+U5nM+Uuh7cyHSJ5wN54twBUGSncJzqpZB83xuZw4VP7UCziQ@mail.gmail.com>
	<16675.1358454278@sss.pgh.pa.us> <m2hamfcwc8.fsf@2ndQuadrant.fr>
	<18941.1358462151@sss.pgh.pa.us> <m2ehhjbf48.fsf@2ndQuadrant.fr>
	<20130118013334.GE3074@awork2.anarazel.de>
	<50F8B400.1090701@2ndQuadrant.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <50F8B400.1090701@2ndQuadrant.com>
Precedence: bulk
Sender: pgsql-hackers-owner@postgresql.org

On 2013-01-18 10:31:28 +0800, Craig Ringer wrote:
> On 01/18/2013 09:33 AM, Andres Freund wrote:
> > I have no problem requiring C code to use the even data, be it via
> > hooks or via C functions called from event triggers. The problem I
> > have with putting in some hooks is that I doubt that you can find
> > sensible spots with enough information to actually recreate the DDL
> > for a remote system without doing most of the work for command triggers.
> 
> Is that so much of a problem if it's OK to break it between major
> versions? Maybe require compilation with -DPG_NON_FORWARD_COMPATIBLE to
> make the hooks visible in the headers, so nobody can claim they didn't know?

I can't follow the connection between what you quote from my mail and
what you are saying ;)

The problem I see is providing enough information to the hooks, not
cross version compatibility. If we go the hook route I don't have the
slightest problem of breaking them in the next releases.

Greetings,

Andres Freund

-- 
 Andres Freund	                   http://www.2ndQuadrant.com/
 PostgreSQL Development, 24x7 Support, Training & Services


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers