Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.72) (envelope-from ) id 1Ty6Z0-000679-BR for pgsql-hackers@arkaria.postgresql.org; Wed, 23 Jan 2013 20:04:50 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.72) (envelope-from ) id 1Ty6Yz-0001hD-Oh for pgsql-hackers@arkaria.postgresql.org; Wed, 23 Jan 2013 20:04:49 +0000 Received: from makus.postgresql.org ([98.129.198.125]) by malur.postgresql.org with esmtp (Exim 4.72) (envelope-from ) id 1Ty6Yw-0001eu-M3 for pgsql-hackers@postgresql.org; Wed, 23 Jan 2013 20:04:46 +0000 Received: from momjian.us ([72.94.173.45]) by makus.postgresql.org with esmtp (Exim 4.72) (envelope-from ) id 1Ty6Yv-0006wt-85 for pgsql-hackers@postgresql.org; Wed, 23 Jan 2013 20:04:45 +0000 Received: from bruce by momjian.us with local (Exim 4.72) (envelope-from ) id 1Ty6Yt-00039d-HS; Wed, 23 Jan 2013 15:04:43 -0500 Date: Wed, 23 Jan 2013 15:04:43 -0500 From: Bruce Momjian To: Robert Haas Cc: Dimitri Fontaine , Alvaro Herrera , PostgreSQL Hackers Subject: Re: Event Triggers: adding information Message-ID: <20130123200443.GI23670@momjian.us> References: <20130123193618.GA29229@momjian.us> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.20 (2009-06-14) X-Pg-Spam-Score: -1.9 (-) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgsql-hackers Precedence: bulk Sender: pgsql-hackers-owner@postgresql.org On Wed, Jan 23, 2013 at 03:02:24PM -0500, Robert Haas wrote: > On Wed, Jan 23, 2013 at 2:36 PM, Bruce Momjian wrote: > > On Wed, Jan 23, 2013 at 09:33:58AM -0500, Robert Haas wrote: > >> On Wed, Jan 23, 2013 at 4:57 AM, Dimitri Fontaine > >> wrote: > >> > Thanks for commiting the fixes. About the regression tests, I think > >> > you're right, but then I can't see how to include such a test. Maybe you > >> > could add the other one, though? > >> > >> Can you point me specifically at what you have in mind so I can make > >> sure I'm considering the right thing? > >> > >> > +1 for this version, thanks. > >> > >> OK, committed that also. > > > > Also, I assume we no longer want after triggers on system tables, so I > > removed that from the TODO list and added event triggers as a completed > > item. > > Seems reasonable. Event triggers are not completed in the sense that > there is a lot more stuff we can do with this architecture, but we've > got a basic implementation now and that's progress. And they do > address the use case that triggers on system tables would have > targeted, I think, but better. Right. Users would always be chasing implementation details if they tried to trigger on system tables. -- Bruce Momjian http://momjian.us EnterpriseDB http://enterprisedb.com + It's impossible for everything to be true. + -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers