From: =?utf-8?q?C=C3=A9dric_Villemain?= <cedric@2ndquadrant.com>
Reply-To: cedric@2ndquadrant.com
Organization: 2ndQuadrant
To: pgsql-hackers@postgresql.org
Subject: Re: Bugfix and new feature for PGXS
Date: Thu, 20 Jun 2013 13:18:31 +0200
User-Agent: KMail/1.13.7 (Linux/3.8-2-amd64; KDE/4.8.4; x86_64; ; )
Cc: Craig Ringer <craig@2ndquadrant.com>, Peter Eisentraut <peter_e@gmx.net>,
 Andrew Dunstan <andrew@dunslane.net>
References: <201306181552.36673.cedric@2ndquadrant.com>
 <1371698781.13762.48.camel@vanquo.pezone.net>
 <51C29153.60708@2ndquadrant.com>
In-Reply-To: <51C29153.60708@2ndquadrant.com>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="nextPart3175486.iMZJXIW4s2";
 protocol="application/pgp-signature"; micalg=pgp-sha1
Content-Transfer-Encoding: 7bit
Message-Id: <201306201318.31428.cedric@2ndquadrant.com>
Precedence: bulk
Sender: pgsql-hackers-owner@postgresql.org

--nextPart3175486.iMZJXIW4s2
Content-Type: Text/Plain;
  charset="utf-8"
Content-Transfer-Encoding: quoted-printable

> Opinions all?
>=20
> * Give up on being able to use one extension's header from another
> entirely, except in the special case of in-tree builds

There are already a good number of use cases with only hstore and intarray,=
=20
I'm in favor of this feature.

> * Install install-enabled contrib headers into an include/contrib/
> that's always on the pgxs include path, so you can still just "#include
> hstore.h" . For in-tree builds, explicit add other modules' contrib dirs
> as Peter has done in the proposed plperl_hstore and plpython_hstore.
> (Use unqualified names).

I don't like the idea to share a flat directory with different header files=
,=20
filenames can overlap.

> * Install install-enabled contrib headers to
> include/contrib/[modulename]/ . Within the module, use the unqualified
> header name. When referring to it from outside the module, use #include
> "contrib/modulename/header.h". Add $(top_srcdir) to the include path
> when building extensions in-tree.

not either, see my other mail. we still #include hstore.h when we want, we=
=20
just add that the header so it is available for PGXS builds. Contrib Makefi=
le=20
still need to -I$(includedir_contrib)/hstore. What's new is that the header=
 is=20
installed, not that we don't have to set FLAGS.

> Personally, I'm all for just using the local path when building the
> module, and the qualified path elsewhere. It requires only a relatively
> simple change, and I don't think that using "hstore.h" within hstore,
> and "contrib/hstore/hstore.h" elsewhere is of great concern.

=2D-=20
C=C3=A9dric Villemain +33 (0)6 20 30 22 52
http://2ndQuadrant.fr/
PostgreSQL: Support 24x7 - D=C3=A9veloppement, Expertise et Formation

--nextPart3175486.iMZJXIW4s2
Content-Type: application/pgp-signature; name=signature.asc 
Content-Description: This is a digitally signed message part.

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.20 (GNU/Linux)

iQEcBAABAgAGBQJRwuUHAAoJENsgH0yzVBebFGoIAIpE5XP8TmkEwr3+v7k6/o7p
Czv/35AJl8fc7ZtVQpkzSLP3XhWkaMLjni8sX91+rIpG4zjfM1yQM4EM1OfhdZeA
jrxySM6QSLSWS9lxz70S7s+YXAETZsCt1/2XMEZS/etPPbczplcD1ltGWcm57FNT
dQkYTf7PwCCudKPb4wI5a+KiPdc8wYCL3gAZmsYUvoHNMfYjkVrMUfqRSh3u8Cde
9YfH82PP3aVc3h5QCjHmNXYJVYJnVjncgwzCV0XYSN9ebO3bffmpxXxVChj0vrga
BiIKXfcHo2/n075tvSqwg19DsmHkqXVOn8tZiteuRvJwSNjkwSt/ZGRENL2CzeY=
=q4L+
-----END PGP SIGNATURE-----

--nextPart3175486.iMZJXIW4s2--