From: =?utf-8?q?C=C3=A9dric_Villemain?= <cedric@2ndquadrant.com>
Reply-To: cedric@2ndquadrant.com
Organization: 2ndQuadrant
To: pgsql-hackers@postgresql.org
Subject: Re: Bugfix and new feature for PGXS
Date: Fri, 12 Jul 2013 23:50:18 +0200
User-Agent: KMail/1.13.7 (Linux/3.9-1-amd64; KDE/4.8.4; x86_64; ; )
Cc: Andrew Dunstan <andrew@dunslane.net>, Josh Berkus <josh@agliodbs.com>,
 Robert Haas <robertmhaas@gmail.com>, Peter Eisentraut <peter_e@gmx.net>,
 Craig Ringer <craig@2ndquadrant.com>
References: <201306181552.36673.cedric@2ndquadrant.com>
 <51DB15CB.9050102@agliodbs.com> <51DB171F.2090108@dunslane.net>
In-Reply-To: <51DB171F.2090108@dunslane.net>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="nextPart2688479.6ms4hTH6iH";
 protocol="application/pgp-signature"; micalg=pgp-sha1
Content-Transfer-Encoding: 7bit
Message-Id: <201307122350.23726.cedric@2ndquadrant.com>
Precedence: bulk
Sender: pgsql-hackers-owner@postgresql.org

--nextPart2688479.6ms4hTH6iH
Content-Type: multipart/mixed;
  boundary="Boundary-01=_boH4RL2mcPFLyNz"
Content-Transfer-Encoding: 7bit


--Boundary-01=_boH4RL2mcPFLyNz
Content-Type: Text/Plain;
  charset="utf-8"
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline

Le lundi 8 juillet 2013 21:46:39, Andrew Dunstan a =C3=A9crit :
> On 07/08/2013 03:40 PM, Josh Berkus wrote:
> > On 07/04/2013 06:18 AM, Andrew Dunstan wrote:
> >> On 07/04/2013 09:14 AM, C=C3=A9dric Villemain wrote:
> >>> ah yes, good catch, I though .control file were unique per contrib,
> >>> but there aren't.
> >>=20
> >> It's already been fixed.
> >=20
> > Does it look like this patch will get into committable shape in the next
> > couple of days?
>=20
> I think everything has been committed - as I think the CF app shows. The
> only thing left in this srea from C=C3=A9dric is the insallation of heade=
rs,
> which Peter is down to review and is in "Waiting on Author" status.

which is returned with feedback now, I can update if someone really wants i=
t.

> We are owed a docco patch though.

Simple one, attached.
I didn't document USE_VPATH, not sure how to explain that clearly.
=2D-=20
C=C3=A9dric Villemain +33 (0)6 20 30 22 52
http://2ndQuadrant.fr/
PostgreSQL: Support 24x7 - D=C3=A9veloppement, Expertise et Formation

--Boundary-01=_boH4RL2mcPFLyNz
Content-Type: text/x-patch;
  charset="UTF-8";
  name="0001-add-documentation-for-commit-6697aa2.patch"
Content-Transfer-Encoding: quoted-printable
Content-Disposition: attachment;
	filename="0001-add-documentation-for-commit-6697aa2.patch"

=46rom 1380870e061362b871c375c25517005f82358dc3 Mon Sep 17 00:00:00 2001
=46rom: =3D?UTF-8?q?C=3DC3=3DA9dric=3D20Villemain?=3D <cedric@2ndquadrant.f=
r>
Date: Fri, 12 Jul 2013 23:39:11 +0200
Subject: [PATCH] add documentation for commit 6697aa2

Document that PGXS offers VPATH build and add a sample like in
installation.sgml

Also update the part about the PGXS global makefile inclusion.
It was suggested to put it at the end, but if the Makefile contains
a target before the include of pgxs then the default all: target is
removed and the Makefile must define all: itself.
=2D--
 doc/src/sgml/extend.sgml |   15 ++++++++++++++-
 1 file changed, 14 insertions(+), 1 deletion(-)

diff --git a/doc/src/sgml/extend.sgml b/doc/src/sgml/extend.sgml
index 60fa1a8..8f082e4 100644
=2D-- a/doc/src/sgml/extend.sgml
+++ b/doc/src/sgml/extend.sgml
@@ -935,7 +935,7 @@ include $(PGXS)
     To use the <acronym>PGXS</acronym> infrastructure for your extension,
     you must write a simple makefile.
     In the makefile, you need to set some variables
=2D    and finally include the global <acronym>PGXS</acronym> makefile.
+    and include the global <acronym>PGXS</acronym> makefile.
     Here is an example that builds an extension module named
     <literal>isbn_issn</literal>, consisting of a shared library containing
     some C code, an extension control file, a SQL script, and a documentat=
ion
@@ -1161,6 +1161,19 @@ include $(PGXS)
     or on the <literal>make</literal> command line.
    </para>
=20
+   <para>
+    You can also run <literal>make</literal> in a directory outside the so=
urce
+    tree of your extension, if you want to keep the build directory separa=
te.
+    This procedure is also called a
+    <indexterm><primary>VPATH</primary></indexterm><firstterm>VPATH</first=
term>
+    build.  Here's how:
+    <screen>
+      <userinput>mkdir build_dir</userinput>
+      <userinput>cd build_dir</userinput>
+      <userinput>make -f /path/to/extension/source/tree/Makefile</userinpu=
t>
+      <userinput>make -f /path/to/extension/source/tree/Makefile install</=
userinput>
+    </screen>
+   </para>
    <caution>
     <para>
      Changing <varname>PG_CONFIG</varname> only works when building
=2D-=20
1.7.10.4


--Boundary-01=_boH4RL2mcPFLyNz--

--nextPart2688479.6ms4hTH6iH
Content-Type: application/pgp-signature; name=signature.asc 
Content-Description: This is a digitally signed message part.

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.20 (GNU/Linux)

iQEcBAABAgAGBQJR4HofAAoJENsgH0yzVBebvMgH/ibHvjp5s1IGI1uL/VbFlNz5
7i580K7xFODaAxMFPPaJusABqeWn7mUgl71qAeoE8acGygBlT/pXhFlGLgf2BqZF
Oqo1u2IpnjstUotJgXRTJO4XjEOh2U1GrEOg4s1AqH/9R8Re6ZfyrI/LJSxrzncx
ajuAn/H6w4kRYmh7DlXLcd//KjaKrE+Bik4+hym/z2GyaPzWKqii68XESXpfkoIe
8G/cjj+c8YvZtdih2Jyt0PqEkb4tlAQQqTyLvJEv/bZNES2E16gqSjhltnydermz
4hhehZA1vRRsjXgBO3tJKAA9xRhK/T4fye0KiU22zPg+Do8jUzRZk6miR5ySL6c=
=ypWX
-----END PGP SIGNATURE-----

--nextPart2688479.6ms4hTH6iH--