Received: from malur.postgresql.org ([217.196.149.56])
 by arkaria.postgresql.org with esmtp (Exim 4.80) (envelope-from
 <pgsql-hackers-owner+M234081=pgsql-hackers-arkari@postgresql.org>)
 id 1VMxgC-000445-In
 for pgsql-hackers@arkaria.postgresql.org; Fri, 20 Sep 2013 10:11:16 +0000
Received: from localhost ([127.0.0.1] helo=postgresql.org)
 by malur.postgresql.org with smtp (Exim 4.80) (envelope-from
 <pgsql-hackers-owner+M234081=pgsql-hackers-arkari@postgresql.org>)
 id 1VMxgB-0000K6-CB
 for pgsql-hackers@arkaria.postgresql.org; Fri, 20 Sep 2013 10:11:15 +0000
Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29])
 by malur.postgresql.org with esmtp (Exim 4.80)
 (envelope-from <kleptog@svana.org>) id 1VMxg1-00005f-3z
 for pgsql-hackers@postgresql.org; Fri, 20 Sep 2013 10:11:05 +0000
Received: from [2400:c400::113:212:99:188] (helo=svana.org)
 by magus.postgresql.org with esmtp (Exim 4.80)
 (envelope-from <kleptog@svana.org>)
 id 1VMxfx-0000C7-DS; Fri, 20 Sep 2013 10:11:04 +0000
Received: from kleptog by svana.org with local (Exim 4.72)
 (envelope-from <kleptog@svana.org>)
 id 1VMxfb-0000FP-VE; Fri, 20 Sep 2013 20:10:41 +1000
Date: Fri, 20 Sep 2013 12:10:39 +0200
From: Martijn van Oosterhout <kleptog@svana.org>
To: Tatsuo Ishii <ishii@postgresql.org>
Cc: robertmhaas@gmail.com, maumau307@gmail.com, tgl@sss.pgh.pa.us,
 maksymb@fast.au.fujitsu.com, hlinnakangas@vmware.com,
 pgsql-hackers@postgresql.org
Message-ID: <20130920101039.GA32048@svana.org>
Reply-To: Martijn van Oosterhout <kleptog@svana.org>
References: <904.1378304922@sss.pgh.pa.us>
 <B1A7485194DE4FDAB8FA781AFB570079@maumau>
 <CA+TgmobWv_96dSfSHv2ZJWSXAD=QTiBEKw-LT359sGArYe+AXQ@mail.gmail.com>
 <20130920.085853.1628917054830864151.t-ishii@sraoss.co.jp>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature"; boundary="sdtB3X0nJg68CQEu"
Content-Disposition: inline
In-Reply-To: <20130920.085853.1628917054830864151.t-ishii@sraoss.co.jp>
X-PGP-Key-ID: Length=4096; ID=0x4BE62D44
X-PGP-Key-Fingerprint: AF6F C0D6 3B8A AF7D 942B  D2BC 4BED FBE7 4BE6 2D44
User-Agent: Mutt/1.5.20 (2009-06-14)
X-SA-Exim-Connect-IP: <locally generated>
X-SA-Exim-Mail-From: kleptog@svana.org
X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on calyx
X-Spam-Level: 
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,NO_RELAYS
 autolearn=ham version=3.3.1
Subject: Re: UTF8 national character data type support WIP patch
 and list of open issues.
X-SA-Exim-Version: 4.2.1 (built Mon, 22 Mar 2010 06:26:47 +0000)
X-SA-Exim-Scanned: Yes (on svana.org)
X-Host-Lookup-Failed: Reverse DNS lookup failed for 2400:c400::113:212:99:188
 (failed)
X-Pg-Spam-Score: -1.1 (-)
List-Archive: <http://archives.postgresql.org/pgsql-hackers>
List-Help: <mailto:majordomo@postgresql.org?body=help>
List-ID: <pgsql-hackers.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@postgresql.org>
List-Post: <mailto:pgsql-hackers@postgresql.org>
List-Subscribe: <mailto:majordomo@postgresql.org?body=sub%20pgsql-hackers>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>
X-Mailing-List: pgsql-hackers
Precedence: bulk
Sender: pgsql-hackers-owner@postgresql.org


--sdtB3X0nJg68CQEu
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, Sep 20, 2013 at 08:58:53AM +0900, Tatsuo Ishii wrote:
> For example, "CREATE TABLE t1(t NCHAR(10))" will succeed if NCHAR is
> UTF-8 and database encoding is UTF-8. Even succeed if NCHAR is
> SHIFT-JIS and database encoding is UTF-8 because there is a conversion
> between UTF-8 and SHIFT-JIS. However will not succeed if NCHAR is
> SHIFT-JIS and database encoding is ISO-8859-1 because there's no
> conversion between them.

As far as I can tell the whole reason for introducing NCHAR is to
support SHIFT-JIS, there hasn't been call for any other encodings, that
I can remember anyway.

So rather than this whole NCHAR thing, why not just add a type
"sjistext", and a few type casts and call it a day...

Have a nice day,
--=20
Martijn van Oosterhout   <kleptog@svana.org>   http://svana.org/kleptog/
> He who writes carelessly confesses thereby at the very outset that he does
> not attach much importance to his own thoughts.
   -- Arthur Schopenhauer

--sdtB3X0nJg68CQEu
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: Digital signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)

iQIVAwUBUjwfHkvt++dL5i1EAQhYUw//VXwmRr4AmvDta/UW7ywqDlrC3FUci45z
ajqRK5BWRo9hmSaEXZddwh1YtsSqp4t+H8FwqX6jkcFMM7yrfy5f8nDmw5YCTELA
uj2PtTfPp9Lxy+Bq7nkvcS8pVSYaSRKlfKV8i/LfKslyuNfADGepaYHlOhmUN2Pk
iTz0CfJIdNl32FKLkpsbmNrDzifj1nWX68GTK7fSqNNyEDs5kA1wOEHo+5m619l0
++E2ORmUnwBJgFbs2eA7nZqHroMIvhRgotVR3yYGft4Rn8mFDXmMKespxNjMmOt1
MbfZZPpHyYXfmYEoIaprFuGJ68fNy8TcAOUS9nHhdloP1FWRTErSROjlih5uCJba
9jkRF6ysj78nqTCza3mJ/wnEkZgrQIvTn6GDTTvXU5T6lyRmrERvvg53ee++nXUz
MQ/3rrBKcnP276gQPwN+uxQ6IrmXREgsK9/MOl4DSCeSUWLW8qHF3uLkweAgrKC9
FTW0DTKglVrtbfC+TWZ2O2Gt4+S32wx4dG1CXQimCVhJqwc4tBpvm2roE6WErY1m
h99NlI89DNLeqflt1m76RQidjRsQO3Lmp5XIAKtRRxcb6o/DcGcQleZ+JX18HOgq
lcofKT8cjVDt1SGVOkruDfl53JO+tVWBrmAOJTGHESr0hOrMxFNTUNEMKEZEYvph
GaHaQ9CE3h0=
=lMsE
-----END PGP SIGNATURE-----

--sdtB3X0nJg68CQEu--