From: Tom Lane <tgl@sss.pgh.pa.us>
To: Robert Haas <robertmhaas@gmail.com>
cc: Etsuro Fujita <fujita.etsuro@lab.ntt.co.jp>,
        Pg Hackers <pgsql-hackers@postgresql.org>,
        Rushabh Lathia <rushabh.lathia@gmail.com>,
        Michael Paquier <michael.paquier@gmail.com>,
        Ashutosh Bapat <ashutosh.bapat@enterprisedb.com>
Subject: Re: postgres_fdw: perform UPDATE/DELETE .. RETURNING on a join
 directly
In-reply-to: 
 <CA+TgmoaAQCn0+xh3JG2avn35Lukj2NVmhxVi7hE2CwzSUQ-5ag@mail.gmail.com>
References: <5A438A45.2000909@lab.ntt.co.jp> <5A57193A.2080003@lab.ntt.co.jp>
 <CA+TgmoYef9czAA1gJeqh4v47Tv=dqOp4EfdU6bV8EYkOdCwvUw@mail.gmail.com>
 <6166.1518044513@sss.pgh.pa.us>
 <CA+TgmoaxGGZyUAWQMz7c-3V85TV5-w2wmvpOYrLnALi2d9Z-dQ@mail.gmail.com>
 <5A7BE8E6.200@lab.ntt.co.jp> <28606.1518105934@sss.pgh.pa.us>
 <CA+Tgmobf+AXEwO4r0oCkvNhkaVnxPgoJaApoX+rAi0G7-N-Dyg@mail.gmail.com>
 <5A7CFDDA.8050906@lab.ntt.co.jp> <5A7D76CF.8080601@lab.ntt.co.jp>
 <CA+TgmoaAQCn0+xh3JG2avn35Lukj2NVmhxVi7hE2CwzSUQ-5ag@mail.gmail.com>
Comments: In-reply-to Robert Haas <robertmhaas@gmail.com>
	message dated "Fri, 09 Feb 2018 11:50:14 -0500"
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="----- =_aaaaaaaaaa0"
Content-ID: <20022.1518201018.0@sss.pgh.pa.us>
Date: Fri, 09 Feb 2018 13:33:08 -0500
Message-ID: <20134.1518201188@sss.pgh.pa.us>
Precedence: bulk

------- =_aaaaaaaaaa0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <20022.1518201018.1@sss.pgh.pa.us>

Robert Haas <robertmhaas@gmail.com> writes:
> Me neither.  I just ran the postgres_fdw regression tests 713 times in
> a row without a failure.  Tom, since you seem to be able to reproduce
> the problem locally, could you have a look at this proposed fix?

I'm a bit busy, but AFAICS it's just a timing thing, so try inserting
a sleep.  The attached is enough to reproduce rhinoceros' results
for me.

			regards, tom lane


------- =_aaaaaaaaaa0
Content-Type: text/x-diff; name="add-sleep.patch"; charset="us-ascii"
Content-ID: <20022.1518201018.2@sss.pgh.pa.us>
Content-Description: add-sleep.patch
Content-Transfer-Encoding: quoted-printable

diff --git a/contrib/postgres_fdw/sql/postgres_fdw.sql b/contrib/postgres_=
fdw/sql/postgres_fdw.sql
index 0b2c528..3f8bd6d 100644
*** a/contrib/postgres_fdw/sql/postgres_fdw.sql
--- b/contrib/postgres_fdw/sql/postgres_fdw.sql
*************** INSERT INTO ft2 (c1,c2,c3)
*** 1133,1138 ****
--- 1133,1139 ----
  EXPLAIN (verbose, costs off)
  UPDATE ft2 SET c3 =3D 'bar' WHERE postgres_fdw_abs(c1) > 2000 RETURNING =
*;            -- can't be pushed down
  UPDATE ft2 SET c3 =3D 'bar' WHERE postgres_fdw_abs(c1) > 2000 RETURNING =
*;
+ select pg_sleep(60);
  EXPLAIN (verbose, costs off)
  UPDATE ft2 SET c3 =3D 'baz'
    FROM ft4 INNER JOIN ft5 ON (ft4.c1 =3D ft5.c1)

------- =_aaaaaaaaaa0--