Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.80) (envelope-from ) id 1XJrvt-0000SC-6i for pgsql-hackers@arkaria.postgresql.org; Tue, 19 Aug 2014 22:31:13 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.80) (envelope-from ) id 1XJrvs-0000rh-IF for pgsql-hackers@arkaria.postgresql.org; Tue, 19 Aug 2014 22:31:12 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256) (Exim 4.80) (envelope-from ) id 1XJrvr-0000rZ-Gw for pgsql-hackers@postgresql.org; Tue, 19 Aug 2014 22:31:11 +0000 Received: from mail.anarazel.de ([217.115.131.40]) by magus.postgresql.org with esmtp (Exim 4.80) (envelope-from ) id 1XJrvn-0004MQ-Py for pgsql-hackers@postgresql.org; Tue, 19 Aug 2014 22:31:10 +0000 Received: by mail.anarazel.de (Postfix, from userid 108) id 3B5A656000A; Wed, 20 Aug 2014 00:31:07 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on mail X-Spam-Level: X-Spam-Status: No, score=-5.8 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.2.5 Received: from anarazel.de (p5DDC6B08.dip0.t-ipconnect.de [93.220.107.8]) (Authenticated sender: andres@anarazel.de) by mail.anarazel.de (Postfix) with ESMTPSA id DE170560009; Wed, 20 Aug 2014 00:31:03 +0200 (CEST) Received: by anarazel.de (Postfix, from userid 1000) id 6F2CF100829; Wed, 20 Aug 2014 00:31:03 +0200 (CEST) Date: Wed, 20 Aug 2014 00:31:03 +0200 From: Andres Freund To: Heikki Linnakangas Cc: Robert Haas , Magnus Hagander , Tom Lane , PostgreSQL-development Subject: Re: PQgetssl() and alternative SSL implementations Message-ID: <20140819223103.GA20476@awork2.anarazel.de> References: <53F1E989.8020609@vmware.com> <10419.1408475397@sss.pgh.pa.us> <53F3C87E.2080401@vmware.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <53F3C87E.2080401@vmware.com> X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgsql-hackers Precedence: bulk Sender: pgsql-hackers-owner@postgresql.org On 2014-08-20 00:58:22 +0300, Heikki Linnakangas wrote: > I don't much like adding a separate function for every SSL implementation, > but you've got a point that it would be nice to make it difficult to call > PQgetSSLstruct() and just assume that the returned struct is e.g an OpenSSL > struct, while it's actually something else. Perhaps: A good reason to not have functions with the respective functions is that it requires either including the relevant headers or adding forward declarations of the libraries type. Greetings, Andres Freund -- Andres Freund http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers