Date: Fri, 30 Jan 2015 12:19:20 -0500
From: Stephen Frost <sfrost@snowman.net>
To: Robert Haas <robertmhaas@gmail.com>
Cc: "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
Subject: Re: tablespaces inside $PGDATA considered harmful
Message-ID: <20150130171920.GJ3854@tamriel.snowman.net>
References: 
 <CA+TgmobZLyLU8tFCbMqbjMWB6t+=ERaDo820uQEJCVAQK_Paow@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
 protocol="application/pgp-signature"; boundary="m4dDEz192B/qme3Z"
Content-Disposition: inline
In-Reply-To: 
 <CA+TgmobZLyLU8tFCbMqbjMWB6t+=ERaDo820uQEJCVAQK_Paow@mail.gmail.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Precedence: bulk
Sender: pgsql-hackers-owner@postgresql.org


--m4dDEz192B/qme3Z
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

* Robert Haas (robertmhaas@gmail.com) wrote:
> Given all this, it seems like a good idea to at least give a warning
> if somebody tries to create a tablespace instead the data directory.

A warning seems like a good idea.  I actually thought we *did* prevent
it..

> Arguably, we should prohibit it altogether, but there are obviously
> people that want to do it, and there could even be somewhat valid
> reasons for that, like wanting to set per-tablespace settings
> differently for different tablespaces.  Possibly we should prohibit it
> anyway, or maybe there should be an option to create a tablespace
> whose directory is a real directory, not a symlink.  So then:
>=20
> CREATE TABLESPACE foo LOCATION '/home/rhaas/pgdata/pg_tblspc/foo';
>=20
> ...would fail, but if you really want a separate tablespace inside the
> data directory, we could allow:
>=20
> CREATE TABLESPACE foo NO LOCATION;
>=20
> ...which would just create a bare directory where the symlink would norma=
lly go.

I actually really like this 'NO LOCATION' idea.  Are there reasons why
that would be difficult or ill-advised to do?

I could see the NO LOCATION approach being useful for migrating between
systems, in particular, or a way to have pg_basebackup work that doesn't
involve having to actually map all the tablespaces...

	Thanks!

		Stephen

--m4dDEz192B/qme3Z
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: Digital signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAEBCgAGBQJUy70YAAoJEO1sijiDR2RVdHwP/2smo6t9WfF67+JoiH3YLiMW
EKtL+TeNtUOOap0qedvqVj5mcQzrVW7Pw7MF4PLGEN8HR1OyBSSd6xfigxhCfm9y
n8pbgxdC3lRos6nt2OrG8SRvU0a4WdeHnDm9nfoVhv2/DKRmixWzHAZxykTsV1jw
aJsLF7BobP6cNkHIkGtC/++r+Nffza83USkhxlMIBQzFWESkcAk4EQ3hyG4h0FL/
WJzQOOjvZVijKCiYpnpHkjjFWXrcWFo6tvtGZEeLWbcbx2wCYvPhRF50H1UVDud6
u00k9iA8jmbCeo4oPYMA7fcCpjE28TUgQM3NHMqIdTPGp9tdJZZRrI2JAytHyCMz
7X82c8KH/X/KiSwlST+JjVTsjCz+UgVmmv9BObEcpHEpQhpD8AShxG/nLPr8J9sT
evicszbS4AFINTpOSsMXPePa6+p0Gl4EBJ5p2IcAmEdXCQ/nLWibQ6al8zyVyZXa
u/YCY6ap1kG4ARp0zWCkedDmfAwKGxc5ox/CXacXz0oFQ8t9z7CRRECDqj78Z3i3
3oUJwkjFacrxvjMc2+RYt27zQgveCrCEfPJrGncteCih+nyPFLBXaGhkSKEoEUzc
79MZQNen76b3kAweY+/QjYdhoip1QMM/6pSGQ25ijMx8rcba4ZAxSvHPo3w55lLC
hIWPhyQk8D39jbuZUul2
=CCHI
-----END PGP SIGNATURE-----

--m4dDEz192B/qme3Z--