Date: Fri, 27 Feb 2015 13:32:36 -0500
From: Stephen Frost <sfrost@snowman.net>
To: Pavel Stehule <pavel.stehule@gmail.com>
Cc: Tomas Vondra <tomas.vondra@2ndquadrant.com>,
 PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Subject: Re: Providing catalog view to pg_hba.conf file - Patch
 submission
Message-ID: <20150227183236.GQ29780@tamriel.snowman.net>
References: <82897A1301080E4B8E461DDAA0FFCF14FD6E@SYD1216>
 <20140629165554.GA5984@toroid.org>
 <20140630070646.GY31357@toroid.org>
 <CAJrrPGe3sZWKFfsHDCJMXfBOqkf6_w6R_DpsUYn2vQK_tVeU1g@mail.gmail.com>
 <54C8156E.1080500@BlueTreble.com>
 <CAJrrPGcFk9_svvipFJeLBrVJYOmq6uNy38NsT8jtfo6Bks5RYw@mail.gmail.com>
 <54C95C4B.2080901@BlueTreble.com>
 <54F09D68.2090700@2ndquadrant.com>
 <20150227165950.GP29780@tamriel.snowman.net>
 <CAFj8pRBo6n4gEQV8J72R0_iXiCa-kZ+j1Ecwk+LrjZRJFN4PhQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
 protocol="application/pgp-signature"; boundary="f5XwDZYQieeN6n9K"
Content-Disposition: inline
In-Reply-To: 
 <CAFj8pRBo6n4gEQV8J72R0_iXiCa-kZ+j1Ecwk+LrjZRJFN4PhQ@mail.gmail.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Precedence: bulk
Sender: pgsql-hackers-owner@postgresql.org


--f5XwDZYQieeN6n9K
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

* Pavel Stehule (pavel.stehule@gmail.com) wrote:
> 2015-02-27 17:59 GMT+01:00 Stephen Frost <sfrost@snowman.net>:
> > I don't think we actually care what the "current contents" are from the
> > backend's point of view- after all, when does an individual backend ever
> > use the contents of pg_hba.conf after it's up and running?  What would
> > make sense, to me at least, would be:
> >
> > pg_hba_configured() -- spits back whatever the config file has
> > pg_hba_active() -- shows what the postmaster is using currently
>=20
> I disagree and I dislike this direction. It is looks like over engineerin=
g.
>=20
> * load every time is wrong, because you will see possibly not active data.

That's the point of the two functions- one to give you what a reload
*now* would, and one to see what's currently active.

> * ignore reload is a attack to mental health of our users.

Huh?

> It should to work like "pg_settings". I need to see "what is wrong in this
> moment" in pg_hba.conf, not what was or what will be wrong.

That's what pg_hba_active() would be from above, yes.

> We can load any config files via admin contrib module - so there is not
> necessary repeat same functionality

That's hardly the same- I can't (easily, anyway) join the results of
pg_read() to pg_hba_active() and see what's different or the same.

	Thanks,

		Stephen

--f5XwDZYQieeN6n9K
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: Digital signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAEBCgAGBQJU8LhEAAoJEO1sijiDR2RVtZsP/3WvvfKPxhNxRpS2idDHhN5z
77+N9AjOoZQnVeVmSNL/yvdyv0AzFZyF1FPOzm56hbL8ZpVqA0IDgnC59zZ02e4q
I5fZV3u2qU78cmiRc02hKkpPvUcHDytL2g1sC58O1uJu3V8P9sF5ogMigq+8LGVt
9/89YWq+dujSe6qT1kNWIWeIlrrT6N4JcF3duRIZ4O5aOpd4Ic/iDp3aJG0D9z8c
fYRbivo6yWSL2gMXGsbfGikB3BmRx/I/Z6c0vnfBAKZove0WpAyaBL783p695Icv
09Ya9plxbXHHxFbb53OTXJbxaS6zbxnYbOoFlCAK1WEOpv7ctcDkhxRq/QwgtRMj
FiPWQqfl+GlbIlgxrRsuSvrjDH6m5CaMR4Uf727qBFGRrifpqc91fR8WCo9iotZv
xUjWRU39Ty/EC6N8v1bAUmyYOe6PuJpeoUbnV4aaHqD63swyZTkFbamoFli9wi0e
otuo5ko5p6CXWY0Mk55pfshMow+Nr9p9iyIHzroKQ8iqW+aNvydvvckc2igtZtwQ
IXKmeDiKnJXsOzPX4dT9WF0KJ7XwsElIXfeQK+ilxexiLasNMNhTM79+6+ErU423
Cj/5lya3k/Al70ZkN6DJgrl9iUvx5/gO+PlDEqLt3BnxLrzvEEiRUh0nFOIs52mv
C/IJrQWcJmqzME5rd20X
=lKkR
-----END PGP SIGNATURE-----

--f5XwDZYQieeN6n9K--