Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.80) (envelope-from ) id 1Ya7WB-0001EV-TI for pgsql-hackers@arkaria.postgresql.org; Mon, 23 Mar 2015 18:56:08 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.80) (envelope-from ) id 1Ya7WB-0003L0-CW for pgsql-hackers@arkaria.postgresql.org; Mon, 23 Mar 2015 18:56:07 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256) (Exim 4.80) (envelope-from ) id 1Ya7WA-0003Ks-0e for pgsql-hackers@postgresql.org; Mon, 23 Mar 2015 18:56:06 +0000 Received: from smtprelay0198.b.hostedemail.com ([64.98.42.198] helo=smtprelay.b.hostedemail.com) by makus.postgresql.org with esmtp (Exim 4.80) (envelope-from ) id 1Ya7W6-0007zW-AW for pgsql-hackers@postgresql.org; Mon, 23 Mar 2015 18:56:04 +0000 Received: from filter.hostedemail.com (10.5.19.248.rfc1918.com [10.5.19.248]) by smtprelay04.b.hostedemail.com (Postfix) with ESMTP id 4B8117B61E; Mon, 23 Mar 2015 18:56:01 +0000 (UTC) X-Session-Marker: 616C76686572726540616C76682E6E6F2D69702E6F7267 X-Spam-Summary: 50, 0, 0, , d41d8cd98f00b204, alvherre@alvh.no-ip.org, :::::::::::, RULES_HIT:41:355:379:599:800:967:973:988:989:1260:1263:1277:1311:1312:1313:1314:1345:1359:1437:1515:1516:1518:1519:1534:1540:1593:1594:1595:1596:1711:1730:1747:1777:1792:2198:2199:2393:2525:2561:2564:2682:2685:2828:2859:2894:2933:2937:2939:2942:2945:2947:2951:2954:3022:3138:3139:3140:3141:3142:3352:3866:3867:3868:3870:3873:3934:3936:3938:3941:3944:3947:3950:3953:3956:3959:4321:4605:4659:5007:6119:6261:7903:7974:9025:9121:10004:10400:10848:11026:11232:11256:11257:11658:11914:12043:12296:12438:12517:12519:12555:12679:12698:12737:13069:13095:13311:13357:13845:13848:13894:13895:21080, 0, RBL:none, CacheIP:none, Bayesian:0.5, 0.5, 0.5, Netcheck:none, DomainCache:0, MSF:not bulk, SPF:fn, MSBL:0, DNSBL:none, Custom_rules:0:0:0 X-HE-Tag: cough57_8ba5b3a837b61 X-Filterd-Recvd-Size: 2310 Received: from alvin.alvh.no-ip.org (unknown [181.43.6.138]) (Authenticated sender: alvherre@alvh.no-ip.org) by omf04.b.hostedemail.com (Postfix) with ESMTPA; Mon, 23 Mar 2015 18:55:59 +0000 (UTC) Received: by alvin.alvh.no-ip.org (Postfix, from userid 1000) id EDB4B1B7B; Mon, 23 Mar 2015 15:17:24 -0300 (CLST) Date: Mon, 23 Mar 2015 15:17:24 -0300 From: Alvaro Herrera To: Sawada Masahiko Cc: David Steele , Abhijit Menon-Sen , Stephen Frost , Fujii Masao , PostgreSQL-development Subject: Re: Auditing extension for PostgreSQL (Take 2) Message-ID: <20150323181724.GG3636@alvh.no-ip.org> References: <54E005CC.1060605@pgmasters.net> <20150217153402.GQ6717@tamriel.snowman.net> <54EB4E56.7050102@pgmasters.net> <54ECA551.8060306@pgmasters.net> <20150323053146.GA1919@toroid.org> <55104204.80008@pgmasters.net> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) X-Pg-Spam-Score: -1.1 (-) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgsql-hackers Precedence: bulk Sender: pgsql-hackers-owner@postgresql.org Sawada Masahiko wrote: > I tied to look into latest patch, but got following error. > > masahiko [pg_audit] $ LANG=C make > gcc -Wall -Wmissing-prototypes -Wpointer-arith > -Wdeclaration-after-statement -Wendif-labels > -Wmissing-format-attribute -Wformat-security -fno-strict-aliasing > -fwrapv -g -fpic -I. -I. -I../../src/include -D_GNU_SOURCE -c -o > pg_audit.o pg_audit.c > pg_audit.c: In function 'log_audit_event': > pg_audit.c:456: warning: ISO C90 forbids mixed declarations and code > pg_audit.c: In function 'pg_audit_ddl_command_end': > pg_audit.c:1436: error: 'pg_event_trigger_expand_command' undeclared > (first use in this function) You need to apply my deparsing patch first, last version of which I posted here: https://www.postgresql.org/message-id/20150316234406.GH3636@alvh.no-ip.org -- Álvaro Herrera http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers