Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.80) (envelope-from ) id 1Yn88L-0006pz-F5 for pgsql-hackers@arkaria.postgresql.org; Tue, 28 Apr 2015 16:13:17 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.80) (envelope-from ) id 1Yn88K-0004Ji-VT for pgsql-hackers@arkaria.postgresql.org; Tue, 28 Apr 2015 16:13:17 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256) (Exim 4.80) (envelope-from ) id 1Yn88J-0004Ja-P4 for pgsql-hackers@postgresql.org; Tue, 28 Apr 2015 16:13:15 +0000 Received: from tamriel.snowman.net ([2001:4830:167b::11]) by magus.postgresql.org with esmtp (Exim 4.80) (envelope-from ) id 1Yn88G-0004bz-4k for pgsql-hackers@postgresql.org; Tue, 28 Apr 2015 16:13:14 +0000 Received: by tamriel.snowman.net (Postfix, from userid 1000) id E506F5F7A1; Tue, 28 Apr 2015 12:13:10 -0400 (EDT) Date: Tue, 28 Apr 2015 12:13:10 -0400 From: Stephen Frost To: Jeff Janes Cc: Tomas Vondra , Kyotaro HORIGUCHI , pgsql-hackers Subject: Re: WIP: multivariate statistics / proof of concept Message-ID: <20150428161310.GR30322@tamriel.snowman.net> References: <54C3FED3.1060600@2ndquadrant.com> <20150320.173307.249113775.horiguchi.kyotaro@lab.ntt.co.jp> <550C8E50.2010600@2ndquadrant.com> <20150324.143427.34552953.horiguchi.kyotaro@lab.ntt.co.jp> <5519E9B2.5080105@2ndquadrant.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="uhZknmokaVn544Hw" Content-Disposition: inline In-Reply-To: X-Editor: Vim http://www.vim.org/ X-Info: http://www.snowman.net X-Operating-System: Linux/3.13.0-46-generic (x86_64) X-Uptime: 12:12:21 up 39 days, 22:01, 20 users, load average: 0.28, 0.17, 0.11 User-Agent: Mutt/1.5.21 (2010-09-15) X-Pg-Spam-Score: -1.9 (-) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgsql-hackers Precedence: bulk Sender: pgsql-hackers-owner@postgresql.org --uhZknmokaVn544Hw Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable * Jeff Janes (jeff.janes@gmail.com) wrote: > On Mon, Mar 30, 2015 at 5:26 PM, Tomas Vondra > wrote: > > attached is a new version of the patch series. Aside from fixing various > > issues (crashes, memory leaks). The patches are rebased to current > > master, and I also attach a few SQL scripts I used for testing (nothing > > fancy, just stress-testing all the parts the patch touches). >=20 > I get cascading conflicts in pg_proc.h. It looked easy enough to fix, > except then I get compiler errors: Yeah, those are because you didn't address the new column which was added to pg_proc. You need to add another _null_ in the pg_proc.h lines in the correct place, apparently on four lines. Thanks! Stephen --uhZknmokaVn544Hw Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBCgAGBQJVP7GWAAoJEO1sijiDR2RVYoQP/i/cfEk/MklwOTpf8VgYaXzO xtOWZzdkavAusINRuaPnzDEL99THPBJLPs4LxyuNy6Mgwuozb1Jichn4TLNND49F REjsIEUqXSdXlGTonemzxeCACfFqY5Gk+LVYtZ1iQFg8u9SDcMhSa8kFN4e3IgpG NmwfXG7SCr0QfWtmH3X9OpClAAQEC2FQltCKAOEsp4cuzyWe84G8i36ARYAZYnfZ M/kTG2UJyVdw+K2lRD73xrEqIRbCjCqgbfkZgDiBg5DOS4EB8kB8z7LvZCMMTh6v HYHn7rw9xLnCWEnf5bXHFmvgethiFIsX7U31wJnuJ2WYX02Xy3Y8JLPycENRTmUu oO8YDOBU5Y32mTpcEbUotXWqbdl/yqBFPeMKuLBFt/Ae6qkVcz4HeS1gZGjFAKng PBmOAmxF/sKsiclpOXNIhH6TUCIfjOswHQWUJCVD4PAyvn0ztv6W6m5e+X3ycrpH 2uSHqTYb3z3jdyGdmiteZSJ2n2avJX1pe4xE2nw2nlo+5DYNEEOmRcLLkD0/o32N /QWz2u0pRUFBfIedkUfLYKifKx1JeRZaWZt93G+bcZ7ToWlTFEAqF9t6AuiCRcZh fE72RueX6+yd0qhLbrHmbdqy3FMPKJ5aOUxsHXerQyjYY3GFFsIrf3R+2AV7v1yy HxpLtu9RXBRH+z9ESdRc =VPjH -----END PGP SIGNATURE----- --uhZknmokaVn544Hw--