Date: Mon, 4 May 2015 15:00:35 -0400
From: Stephen Frost <sfrost@snowman.net>
To: Peter Eisentraut <peter_e@gmx.net>
Cc: Fujii Masao <masao.fujii@gmail.com>,
 Sawada Masahiko <sawada.mshk@gmail.com>,
 David Steele <david@pgmasters.net>, Simon Riggs <simon@2ndquadrant.com>,
 Tatsuo Ishii <ishii@postgresql.org>,
 PostgreSQL-development <pgsql-hackers@postgresql.org>,
 Abhijit Menon-Sen <ams@2ndquadrant.com>
Subject: Re: Auditing extension for PostgreSQL (Take 2)
Message-ID: <20150504190035.GO30322@tamriel.snowman.net>
References: <552EA121.1090603@pgmasters.net>
 <CAD21AoBoS6Q5yjB05LpfKTzhKmarqwwVq06fuPDFsm0T8gSk_Q@mail.gmail.com>
 <5534FC6E.9030906@pgmasters.net>
 <CAD21AoCxFOLWk-k179PyFxzwjkOW8oPaNk73GxZi+Yw2+n4YFA@mail.gmail.com>
 <553938A1.7030707@pgmasters.net>
 <CAD21AoDBt44ABM_0WMketM8bZtqLBMrJpd9RD5tE=Dkr57ft_A@mail.gmail.com>
 <553FA477.5010803@pgmasters.net>
 <CAD21AoCQSGZ5x+sfs4g1x_8Fip60x8ULQFTAGB5XTrKQZvPWPA@mail.gmail.com>
 <CAHGQGwGJnRW69rSL1=tza571_eA44hBeChg-NAVrqQytESgvLg@mail.gmail.com>
 <55443ED1.6070003@gmx.net>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
 protocol="application/pgp-signature"; boundary="HjItbSCiIUf1YjO/"
Content-Disposition: inline
In-Reply-To: <55443ED1.6070003@gmx.net>
User-Agent: Mutt/1.5.21 (2010-09-15)
Precedence: bulk
Sender: pgsql-hackers-owner@postgresql.org


--HjItbSCiIUf1YjO/
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

* Peter Eisentraut (peter_e@gmx.net) wrote:
> On 4/30/15 6:05 AM, Fujii Masao wrote:
> > The specification of "session audit logging" seems to be still unclear =
to me.
>=20
> As I had mentioned previously, I would prefer session audit logging to
> be integrated with the normal statement logging configuration.

I'd certainly love to see the logging in core be improved, but that's
also rather tangential to this extension and we could certainly have
both quite happily.  Further, being able to configure and have
consistent information from the extension is valuable even if options
are added to the in-core logging to make it more flexible.

One particular advantage of having the extension is that having it
doesn't impact existing users of the in-core logging system.  I don't
recall any specific proposals for improving the in-core logging system
to add the capabilities for session logging that the extension
provides, but it seems likely to require changes to at least the CSV
format, new log_line_prefix escape codes (which we're using quite a
few of already...), new GUCs, and potentially behavior changes to make
it work.  As I say above, I'm happy to have those discussions (and
I've been party to them quite a few times in the past...), but it
seems unlikely to seriously reduce the usefulness of session logging
being in the extension and producing consistent output with the object
logging.

	Thanks!

		Stephen

--HjItbSCiIUf1YjO/
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: Digital signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAEBCgAGBQJVR8HTAAoJEO1sijiDR2RVl+sP/3ItjVJjUPbVeZQrBNTDtL9H
Xl2i1gBX0T28sMb4C9gjP05WTSATMf+B+skgE8VyH6CqGdqxeSqhrjHgHW994eHO
11TibW+CvswlBUbj3UQivQlr5Z6VVL6JqxLIaODbGjrvLLjMTR5PLncSoEAukmVj
FwOJ5mtBFb/Mnh33nDcyfwlBKZE8wGia1wk0wfqwH9Zu4HZk3E4di/ttSmDAjWxc
j2Nt840pK/2OIQ88t7GoUSS1HvMNaOH4x609RXvEbi2wwd8IKtNzutXmM5VBZVCr
lfg+bWpwqlYh+Vex1F5ESxxTTeF0D1lMHhpgF6NbOQDrl4idnt+JrAIQ1QCjyj61
ae88HRbWXF6JBqwBbCgAmUL695lIUbFMTIAGByPhxhbH/6ZotGhna7iC0Nn/KAYG
jCW3pXxeInDC+iCfufe9mwZCETN8oCrsgcTzuoQXiK9SLIfPu+1S7goDkbYQqkzZ
WfovBltHcTB/DKVRvlSXJ9SgInAfl9nrqSVQ6Foi3u5T5Gc0g5NPe2IN3CZQ0Agz
ngQSkcMb328tjELOoS4HBEE2D6P19y128U9OP1O78r7WTqQXaEU/HfASkmWDsXeA
Bazi62tCHtJcpLlQdfMw+DNgf3V7JUN6aKgL/p7vjINhvsGIFnw6SpIA5aX0r8zU
U1slwAoRuUUqrYoBYXu3
=gjZA
-----END PGP SIGNATURE-----

--HjItbSCiIUf1YjO/--