Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.80) (envelope-from ) id 1Z09VJ-00059q-K2 for pgsql-hackers@arkaria.postgresql.org; Wed, 03 Jun 2015 14:18:49 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.80) (envelope-from ) id 1Z09VJ-0008EI-1P for pgsql-hackers@arkaria.postgresql.org; Wed, 03 Jun 2015 14:18:49 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:RSA_AES_256_CBC_SHA256:256) (Exim 4.80) (envelope-from ) id 1Z09VG-0008Dj-MZ; Wed, 03 Jun 2015 14:18:46 +0000 Received: from mail.anarazel.de ([217.115.131.40]) by makus.postgresql.org with esmtp (Exim 4.84) (envelope-from ) id 1Z09VD-0006WW-Nz; Wed, 03 Jun 2015 14:18:45 +0000 Received: by mail.anarazel.de (Postfix, from userid 108) id 3AE79860002; Wed, 3 Jun 2015 16:18:42 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on mail X-Spam-Level: X-Spam-Status: No, score=-4.8 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.2.5 Received: from anarazel.de (p54AF45D0.dip0.t-ipconnect.de [84.175.69.208]) (Authenticated sender: andres@anarazel.de) by mail.anarazel.de (Postfix) with ESMTPSA id BCFBD860001; Wed, 3 Jun 2015 16:18:38 +0200 (CEST) Received: by anarazel.de (Postfix, from userid 1000) id 057251016D2; Wed, 3 Jun 2015 16:18:37 +0200 (CEST) Date: Wed, 3 Jun 2015 16:18:37 +0200 From: Andres Freund To: Noah Misch Cc: Bruce Momjian , Robert Haas , Tom Lane , Stephen Frost , Magnus Hagander , "pgsql-hackers@postgresql.org" , pgsql-core Subject: Re: Restore-reliability mode Message-ID: <20150603141837.GD18006@awork2.anarazel.de> References: <28477.1432931820@sss.pgh.pa.us> <20150529223321.GB6535@alap3.anarazel.de> <12510.1432958887@sss.pgh.pa.us> <20150530154559.GA25053@momjian.us> <20150530204727.GJ13944@alap3.anarazel.de> <20150531024845.GB13697@momjian.us> <20150603135049.GA74753@tornado.leadboat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150603135049.GA74753@tornado.leadboat.com> X-Pg-Spam-Score: -4.2 (----) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgsql-hackers Precedence: bulk Sender: pgsql-hackers-owner@postgresql.org On 2015-06-03 09:50:49 -0400, Noah Misch wrote: > Second, I would define the subject matter as "bug fixes, testing and > review", not "restructuring, testing and review." Different code > structures are clearest to different hackers. Restructuring, on > average, adds bugs even more quickly than feature development adds > them. I can't agree with this. While I agree with not doing large restructuring for 9.5, I think we can't affort not to refactor for clarity, even if that introduces bugs. Noticeable parts of our code have to frequently be modified for new features and are badly structured at the same time. While restructuring will may temporarily increase the number of bugs in the short term, it'll decrease the number of bugs long term while increasing the number of potential contributors and new features. That's obviously not to say we should just refactor for the sake of it. -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers