Date: Fri, 23 Oct 2015 14:50:58 -0300
From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Jeff Janes <jeff.janes@gmail.com>
Cc: Thomas Munro <thomas.munro@enterprisedb.com>,
 Tom Lane <tgl@sss.pgh.pa.us>,
 Pg Hackers <pgsql-hackers@postgresql.org>
Subject: Re: Making tab-complete.c easier to maintain
Message-ID: <20151023175058.GA3391@alvherre.pgsql>
References: 
 <CAEepm=2wF0eTXfQUMzvJ71GC47ESQmWQ3Y_fz5CRBask1uA1DA@mail.gmail.com>
 <17081.1441374043@sss.pgh.pa.us>
 <CAEepm=0QKjnVVq9ueBXP5yntNFwtFZhFzLPEOpCA-PPoh0NieQ@mail.gmail.com>
 <20150907135605.GP2912@alvherre.pgsql>
 <CAEepm=3q9oBsd65F3AMTKw9-Rs+E+SDV3HpGV5yLj7ySetj7Yw@mail.gmail.com>
 <CAEepm=1=Hdt9TCM3BRiVE6NCnXHyDDki+YVPhfZ02_=niU=8cA@mail.gmail.com>
 <CAMkU=1yt=Ed7+K4sUisdUkt-wDhGnxdkDqs_43uJvhJYFA56gQ@mail.gmail.com>
 <CAEepm=1ns0rbo+xun_j6_PwDT6zmEPuNggy=Vaie-3peF2C44Q@mail.gmail.com>
 <CAMkU=1zRsaaSF_8qyQNYqOcDt0Xa7Awk==YdWCeTZtNhjnPNww@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: 
 <CAMkU=1zRsaaSF_8qyQNYqOcDt0Xa7Awk==YdWCeTZtNhjnPNww@mail.gmail.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Precedence: bulk
Sender: pgsql-hackers-owner@postgresql.org

Jeff Janes wrote:

> For the bigger picture, I don't think we should not apply this patch simply
> because there is something even better we might theoretically do at some
> point in the future.

Agreed.

> Having used it a little bit, I do agree with Robert
> that it is not a gigantic improvement over the current situation, as the
> code it replaces is largely mechanical boilerplate.  But I think it is
> enough of an improvement that we should go ahead with it.

To me this patch sounds much like 2eafcf68d563df8a1db80a.  You could say
that what was replaced was "largely mechanical", but it was so much
easier to make mistakes with the original coding that it's not funny.

-- 
Álvaro Herrera                http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers