Received: from malur.postgresql.org ([217.196.149.56])
 by arkaria.postgresql.org with esmtp (Exim 4.80) (envelope-from
 <pgsql-hackers-owner+M285249=pgsql-hackers-arkari@postgresql.org>)
 id 1ZyLaO-0003tS-Lq
 for pgsql-hackers@arkaria.postgresql.org; Mon, 16 Nov 2015 15:20:52 +0000
Received: from localhost ([127.0.0.1] helo=postgresql.org)
 by malur.postgresql.org with smtp (Exim 4.84) (envelope-from
 <pgsql-hackers-owner+M285249=pgsql-hackers-arkari@postgresql.org>)
 id 1ZyLaO-0004S9-3l
 for pgsql-hackers@arkaria.postgresql.org; Mon, 16 Nov 2015 15:20:52 +0000
Received: from makus.postgresql.org ([2001:4800:1501:1::229])
 by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256)
 (Exim 4.84) (envelope-from <alvherre@alvh.no-ip.org>)
 id 1ZyLZ3-0002v6-R8
 for pgsql-hackers@postgresql.org; Mon, 16 Nov 2015 15:19:29 +0000
Received: from out.smtp-auth.no-ip.com ([8.23.224.60])
 by makus.postgresql.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:256)
 (Exim 4.84) (envelope-from <alvherre@alvh.no-ip.org>)
 id 1ZyLZ0-0003xp-Uu
 for pgsql-hackers@postgresql.org; Mon, 16 Nov 2015 15:19:28 +0000
X-No-IP: alvh.no-ip.org@noip-smtp
X-Report-Spam-To: abuse@no-ip.com
Received: from alvin.alvh.no-ip.org (unknown [200.104.53.52])
 (Authenticated sender: alvh.no-ip.org@noip-smtp)
 by smtp-auth.no-ip.com (Postfix) with ESMTPA id 8CA72400E24;
 Mon, 16 Nov 2015 07:19:25 -0800 (PST)
Received: by alvin.alvh.no-ip.org (Postfix, from userid 1000)
 id 43917C7F; Mon, 16 Nov 2015 12:19:23 -0300 (CLT)
Date: Mon, 16 Nov 2015 12:19:23 -0300
From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Thomas Munro <thomas.munro@enterprisedb.com>
Cc: Jeff Janes <jeff.janes@gmail.com>, Tom Lane <tgl@sss.pgh.pa.us>,
 Pg Hackers <pgsql-hackers@postgresql.org>
Subject: Re: Making tab-complete.c easier to maintain
Message-ID: <20151116151923.GX614468@alvherre.pgsql>
References: <17081.1441374043@sss.pgh.pa.us>
 <CAEepm=0QKjnVVq9ueBXP5yntNFwtFZhFzLPEOpCA-PPoh0NieQ@mail.gmail.com>
 <20150907135605.GP2912@alvherre.pgsql>
 <CAEepm=3q9oBsd65F3AMTKw9-Rs+E+SDV3HpGV5yLj7ySetj7Yw@mail.gmail.com>
 <CAEepm=1=Hdt9TCM3BRiVE6NCnXHyDDki+YVPhfZ02_=niU=8cA@mail.gmail.com>
 <CAMkU=1yt=Ed7+K4sUisdUkt-wDhGnxdkDqs_43uJvhJYFA56gQ@mail.gmail.com>
 <CAEepm=1ns0rbo+xun_j6_PwDT6zmEPuNggy=Vaie-3peF2C44Q@mail.gmail.com>
 <CAMkU=1zRsaaSF_8qyQNYqOcDt0Xa7Awk==YdWCeTZtNhjnPNww@mail.gmail.com>
 <CAEepm=1Oaq+L_6KCZ5o_hNn-=T93_LiK=_T1C9DcPzgXs4H84g@mail.gmail.com>
 <CAEepm=1EOiP9_fKfb2B_ncp2hWYFxWEM+OsoD-=-iL_Wh=46Vg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: 
 <CAEepm=1EOiP9_fKfb2B_ncp2hWYFxWEM+OsoD-=-iL_Wh=46Vg@mail.gmail.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
X-Pg-Spam-Score: -2.6 (--)
List-Archive: <http://archives.postgresql.org/pgsql-hackers>
List-Help: <mailto:majordomo@postgresql.org?body=help>
List-ID: <pgsql-hackers.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@postgresql.org>
List-Post: <mailto:pgsql-hackers@postgresql.org>
List-Subscribe: <mailto:majordomo@postgresql.org?body=sub%20pgsql-hackers>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>
X-Mailing-List: pgsql-hackers
Precedence: bulk
Sender: pgsql-hackers-owner@postgresql.org

Thomas Munro wrote:
> New version attached, merging recent changes.

I wonder about the TailMatches and Matches macros --- wouldn't it be
better to have a single one, renaming TailMatches to Matches and
replacing the current Matches() with an initial token that corresponds
to anchoring to start of command?  Just wondering, not terribly attached
to the idea.

-- 
Álvaro Herrera                http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers