Received: from malur.postgresql.org ([217.196.149.56])
 by arkaria.postgresql.org with esmtp (Exim 4.80) (envelope-from
 <pgsql-hackers-owner+M285477=pgsql-hackers-arkari@postgresql.org>)
 id 1ZzRX6-000541-Ed
 for pgsql-hackers@arkaria.postgresql.org; Thu, 19 Nov 2015 15:54:00 +0000
Received: from localhost ([127.0.0.1] helo=postgresql.org)
 by malur.postgresql.org with smtp (Exim 4.84) (envelope-from
 <pgsql-hackers-owner+M285477=pgsql-hackers-arkari@postgresql.org>)
 id 1ZzRX5-0003Kr-Vf
 for pgsql-hackers@arkaria.postgresql.org; Thu, 19 Nov 2015 15:54:00 +0000
Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29])
 by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256)
 (Exim 4.84) (envelope-from <alvherre@alvh.no-ip.org>)
 id 1ZzRVm-0001Pc-3b
 for pgsql-hackers@postgresql.org; Thu, 19 Nov 2015 15:52:38 +0000
Received: from out.smtp-auth.no-ip.com ([8.23.224.60])
 by magus.postgresql.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:256)
 (Exim 4.84) (envelope-from <alvherre@alvh.no-ip.org>)
 id 1ZzRVh-0003kb-LB
 for pgsql-hackers@postgresql.org; Thu, 19 Nov 2015 15:52:37 +0000
X-No-IP: alvh.no-ip.org@noip-smtp
X-Report-Spam-To: abuse@no-ip.com
Received: from alvin.alvh.no-ip.org (unknown [200.132.66.10])
 (Authenticated sender: alvh.no-ip.org@noip-smtp)
 by smtp-auth.no-ip.com (Postfix) with ESMTPA id E971C4006BD;
 Thu, 19 Nov 2015 07:52:25 -0800 (PST)
Received: by alvin.alvh.no-ip.org (Postfix, from userid 1000)
 id D964BD0F; Thu, 19 Nov 2015 12:52:22 -0300 (CLT)
Date: Thu, 19 Nov 2015 13:52:22 -0200
From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Jeff Janes <jeff.janes@gmail.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: GIN pending list clean up exposure to SQL
Message-ID: <20151119155222.GJ614468@alvherre.pgsql>
References: 
 <CAMkU=1x8zFkpfnozXyt40zmR3Ub_kHu58LtRmwHUKRgQss7=iQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: 
 <CAMkU=1x8zFkpfnozXyt40zmR3Ub_kHu58LtRmwHUKRgQss7=iQ@mail.gmail.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
X-Pg-Spam-Score: -2.6 (--)
List-Archive: <http://archives.postgresql.org/pgsql-hackers>
List-Help: <mailto:majordomo@postgresql.org?body=help>
List-ID: <pgsql-hackers.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@postgresql.org>
List-Post: <mailto:pgsql-hackers@postgresql.org>
List-Subscribe: <mailto:majordomo@postgresql.org?body=sub%20pgsql-hackers>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>
X-Mailing-List: pgsql-hackers
Precedence: bulk
Sender: pgsql-hackers-owner@postgresql.org

Jeff Janes wrote:
> I've written a function which allows users to clean up the pending list.
> It takes the index name and returns the number of pending list pages
> deleted.

I just noticed that your patch uses AccessShareLock on the index.  Is
that okay?  I would have assumed that you'd need ShareUpdateExclusive
(same as vacuum uses), but I don't really know.  Was that a carefully
thought-out choice?

-- 
Álvaro Herrera                http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers