Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.80) (envelope-from ) id 1aEHd3-0004L5-QI for pgsql-hackers@arkaria.postgresql.org; Wed, 30 Dec 2015 14:21:29 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84) (envelope-from ) id 1aEHd3-0000NT-Cy for pgsql-hackers@arkaria.postgresql.org; Wed, 30 Dec 2015 14:21:29 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84) (envelope-from ) id 1aEHd2-0000Mh-0h for pgsql-hackers@postgresql.org; Wed, 30 Dec 2015 14:21:28 +0000 Received: from out.smtp-auth.no-ip.com ([8.23.224.60]) by makus.postgresql.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84) (envelope-from ) id 1aEHcz-0002Pa-8w for pgsql-hackers@postgresql.org; Wed, 30 Dec 2015 14:21:26 +0000 X-No-IP: alvh.no-ip.org@noip-smtp X-Report-Spam-To: abuse@no-ip.com Received: from alvin.alvh.no-ip.org (unknown [200.104.53.52]) (Authenticated sender: alvh.no-ip.org@noip-smtp) by smtp-auth.no-ip.com (Postfix) with ESMTPA id 30056400D0E; Wed, 30 Dec 2015 06:21:20 -0800 (PST) Received: by alvin.alvh.no-ip.org (Postfix, from userid 1000) id 3ADBB1D48; Wed, 30 Dec 2015 11:21:18 -0300 (CLT) Date: Wed, 30 Dec 2015 11:21:18 -0300 From: Alvaro Herrera To: Michael Paquier Cc: Thomas Munro , Tom Lane , Kyotaro HORIGUCHI , Jeff Janes , PostgreSQL mailing lists Subject: Re: Making tab-complete.c easier to maintain Message-ID: <20151230142118.GV58441@alvherre.pgsql> References: <1851.1450471370@sss.pgh.pa.us> <21460.1450560248@sss.pgh.pa.us> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgsql-hackers Precedence: bulk Sender: pgsql-hackers-owner@postgresql.org Michael Paquier wrote: > OK, here are new patches. > - 0001 switches a bunch of TailMatches to Matches. Do we want to care > about the case where a schema is created following by a bunch of > objects? I mean stuff like "CREATE SCHEMA hoge CREATE TABLE ..." where > the current completion would work fine. The performance gains seem > worth it compared to the number of people actually using it, the point > has just not been raised yet. I'd rather have the completion work for that case than get a few microseconds speedup. As far as I recall, it's only four commands that must retain the old coding. -- Álvaro Herrera http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers