Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.80) (envelope-from ) id 1aEICx-0005tI-B6 for pgsql-hackers@arkaria.postgresql.org; Wed, 30 Dec 2015 14:58:35 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84) (envelope-from ) id 1aEICw-000417-Ql for pgsql-hackers@arkaria.postgresql.org; Wed, 30 Dec 2015 14:58:34 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84) (envelope-from ) id 1aEICw-000411-2K for pgsql-hackers@postgresql.org; Wed, 30 Dec 2015 14:58:34 +0000 Received: from newmail.postgrespro.ru ([93.174.131.138] helo=mail.postgrespro.ru) by makus.postgresql.org with esmtp (Exim 4.84) (envelope-from ) id 1aEICp-00039i-1c for pgsql-hackers@postgresql.org; Wed, 30 Dec 2015 14:58:32 +0000 Received: from localhost (localhost [127.0.0.1]) by mail.postgrespro.ru (Postfix) with ESMTP id C289721C53BF; Wed, 30 Dec 2015 17:58:24 +0300 (MSK) Received: from mail.postgrespro.ru ([127.0.0.1]) by localhost (mail.postgrespro.ru [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 4PqNgc0EE1O3; Wed, 30 Dec 2015 17:58:24 +0300 (MSK) Received: from fujitsu (unknown [192.168.27.1]) by mail.postgrespro.ru (Postfix) with ESMTPSA id 0266721C53B6; Wed, 30 Dec 2015 17:58:24 +0300 (MSK) Date: Wed, 30 Dec 2015 17:56:31 +0300 From: Aleksander Alekseev To: Alvaro Herrera Cc: Andres Freund , Robert Haas , Teodor Sigaev , "pgsql-hackers@postgresql.org" Subject: Re: Patch: fix lock contention for HASHHDR.mutex Message-ID: <20151230175631.4b443bef@fujitsu> In-Reply-To: <20151230144913.GY58441@alvherre.pgsql> References: <20151217190342.07e4533a@fujitsu> <56740E41.4010708@sigaev.ru> <20151222183953.771cb58b@fujitsu> <20151228120112.6a847dfd@fujitsu> <20151229184851.1bb7d1bd@fujitsu> <20151230143719.GX58441@alvherre.pgsql> <20151230144409.vrf6i2p7zvwez4xl@alap3.anarazel.de> <20151230144913.GY58441@alvherre.pgsql> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Pg-Spam-Score: -1.9 (-) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgsql-hackers Precedence: bulk Sender: pgsql-hackers-owner@postgresql.org Agree. --enable-depend turned on by default could save me a lot of time. Now I'm aware regarding --enable-depend and `make clean`. Still other people will definitely do the same mistake over and over again. On Wed, 30 Dec 2015 11:49:13 -0300 Alvaro Herrera wrote: > Andres Freund wrote: > > On 2015-12-30 11:37:19 -0300, Alvaro Herrera wrote: > > > Aleksander Alekseev wrote: > > > > > > > Here is a funny thing - benchmark results I shared 22.12.2015 > > > > are wrong because I forgot to run `make clean` after changing > > > > lwlock.h (autotools doesn't rebuild project properly after > > > > changing .h files). > > > > > > Running configure with --enable-depend should avoid this problem. > > > > I still maintain that --enable-depend should be on by default. > > +1 Let's do it. > -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers