From: Tom Lane <tgl@sss.pgh.pa.us>
To: Nathan Bossart <nathandbossart@gmail.com>
cc: Kyotaro Horiguchi <horikyota.ntt@gmail.com>, michael@paquier.xyz,
        gurjeet@singh.im, pgsql-hackers@postgresql.org
Subject: Re: Unprivileged user can induce crash by using an SUSET param in
 PGOPTIONS
In-reply-to: <20220725043044.GC4085281@nathanxps13>
References: 
 <CABwTF4WXCbjEpVRq+G+MZeJEXU=2evYMb_DVdzXpWap5cczkcQ@mail.gmail.com>
 <Ytn2ssEKdzPFM3Vf@paquier.xyz>
 <20220722.151600.1094104349120879204.horikyota.ntt@gmail.com>
 <729330.1658516182@sss.pgh.pa.us> <20220722223359.GB3998906@nathanxps13>
 <763512.1658529844@sss.pgh.pa.us> <20220722225615.GC3998906@nathanxps13>
 <954936.1658597004@sss.pgh.pa.us> <20220725034040.GA4085281@nathanxps13>
 <1834276.1658720963@sss.pgh.pa.us> <20220725043044.GC4085281@nathanxps13>
Comments: In-reply-to Nathan Bossart <nathandbossart@gmail.com>
	message dated "Sun, 24 Jul 2022 21:30:44 -0700"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <2015980.1658759562.1@sss.pgh.pa.us>
Date: Mon, 25 Jul 2022 10:32:42 -0400
Message-ID: <2015981.1658759562@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/2015981.1658759562%40sss.pgh.pa.us>
Precedence: bulk

Nathan Bossart <nathandbossart@gmail.com> writes:
> Given all this, I think I'm inclined for the new argument.

Pushed like that then (after a bit more fooling with the comments).

I haven't done anything about a test case.  We can't rely on plperl
getting built, and even if we could, it doesn't have any TAP-style
tests so it'd be hard to get it to test this scenario.  However,
I do see that we're not testing session_preload_libraries anywhere,
which seems bad.  I wonder if it'd be a good idea to convert
auto_explain's TAP test to load auto_explain via session_preload_libraries
instead of shared_preload_libraries, and then pass in the settings for
each test via PGOPTIONS instead of constantly rewriting postgresql.conf.

			regards, tom lane