Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.80) (envelope-from ) id 1aOOZz-0003ac-Dc for pgsql-hackers@arkaria.postgresql.org; Wed, 27 Jan 2016 11:48:07 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84) (envelope-from ) id 1aOOZy-0005dC-BF for pgsql-hackers@arkaria.postgresql.org; Wed, 27 Jan 2016 11:48:06 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84) (envelope-from ) id 1aOOZw-0005ce-F9 for pgsql-hackers@postgresql.org; Wed, 27 Jan 2016 11:48:04 +0000 Received: from newmail.postgrespro.ru ([93.174.131.138] helo=mail.postgrespro.ru) by magus.postgresql.org with esmtp (Exim 4.84) (envelope-from ) id 1aOOZp-0000eD-E5 for pgsql-hackers@postgresql.org; Wed, 27 Jan 2016 11:48:04 +0000 Received: from localhost (localhost [127.0.0.1]) by mail.postgrespro.ru (Postfix) with ESMTP id 0944E21C5C90; Wed, 27 Jan 2016 14:47:56 +0300 (MSK) Received: from mail.postgrespro.ru ([127.0.0.1]) by localhost (mail.postgrespro.ru [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id sLTc-tSTM3QS; Wed, 27 Jan 2016 14:47:55 +0300 (MSK) Received: from fujitsu (unknown [192.168.27.1]) by mail.postgrespro.ru (Postfix) with ESMTPSA id 38E1321C5C8E; Wed, 27 Jan 2016 14:47:55 +0300 (MSK) Date: Wed, 27 Jan 2016 14:45:42 +0300 From: Aleksander Alekseev To: Dilip Kumar Cc: "pgsql-hackers@postgresql.org" Subject: Re: Patch: fix lock contention for HASHHDR.mutex Message-ID: <20160127144542.224c0741@fujitsu> In-Reply-To: References: <20151230160137.034371e0@fujitsu> <20160112001642.GA802875@alvherre.pgsql> <20160112112005.26675392@fujitsu> <20160122131432.2f11dac4@fujitsu> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Pg-Spam-Score: -1.9 (-) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgsql-hackers Precedence: bulk Sender: pgsql-hackers-owner@postgresql.org > > This patch affects header files. By any chance didn't you forget to > > run `make clean` after applying it? As we discussed above, when you > > change .h files autotools doesn't rebuild dependent .c files: > > > > Yes, actually i always compile using "make clean;make -j20; make > install" If you want i will run it again may be today or tomorrow and > post the result. > > Most likely HASHHDR.mutex is not only bottleneck in your case so my patch doesn't help much. Unfortunately I don't have access to any POWER8 server so I can't investigate this issue. I suggest to use a gettimeofday trick I described in a first message of this thread. Its time consuming but it gives a clear understanding which code is keeping a lock. -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers