Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1afv3D-0002CO-Od for pgsql-hackers@arkaria.postgresql.org; Tue, 15 Mar 2016 19:54:43 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1afv3C-0007j0-Pj for pgsql-hackers@arkaria.postgresql.org; Tue, 15 Mar 2016 19:54:42 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1afv3A-0007hP-OZ for pgsql-hackers@postgresql.org; Tue, 15 Mar 2016 19:54:40 +0000 Received: from tamriel.snowman.net ([2001:4830:167b::11]) by magus.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1afv37-0006pF-IM for pgsql-hackers@postgresql.org; Tue, 15 Mar 2016 19:54:40 +0000 Received: by tamriel.snowman.net (Postfix, from userid 1000) id DED055F796; Tue, 15 Mar 2016 15:54:36 -0400 (EDT) Date: Tue, 15 Mar 2016 15:54:36 -0400 From: Stephen Frost To: Robbie Harwood Cc: Michael Paquier , David Steele , Pg Hackers Subject: Re: [PATCH v6] GSSAPI encryption support Message-ID: <20160315195436.GE3127@tamriel.snowman.net> References: <56E81852.1060005@pgmasters.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="/RvYOEQaqo9O34Ko" Content-Disposition: inline In-Reply-To: X-Editor: Vim http://www.vim.org/ X-Info: http://www.snowman.net X-Operating-System: Linux/3.13.0-77-generic (x86_64) X-Uptime: 15:52:12 up 21 days, 16:45, 5 users, load average: 0.23, 0.16, 0.14 User-Agent: Mutt/1.5.21 (2010-09-15) X-Pg-Spam-Score: -1.9 (-) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgsql-hackers Precedence: bulk Sender: pgsql-hackers-owner@postgresql.org --/RvYOEQaqo9O34Ko Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Robbie, * Robbie Harwood (rharwood@redhat.com) wrote: > Michael Paquier writes: > > - maj_stat =3D gss_accept_sec_context( > > - &min_stat, > > + maj_stat =3D gss_accept_sec_context(&min_stat, > > > > This is just noise. >=20 > You're not wrong, though I do think it makes the code more readable by > enforcing style and this is a "cleanup" commit. I'll take it out if it > bothers you. First, thanks much for working on this, I've been following along the discussions and hope to be able to help move it to commit, once it's ready. Secondly, generally, speaking, we prefer that 'cleanup' type changes (particularly whitespace-only ones) are in independent commits which are marked as just whitespace/indentation changes. We have a number of organizations which follow our code changes and it makes it more difficult on them to include whitespace/indentation changes with code changes. Thanks! Stephen --/RvYOEQaqo9O34Ko Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIbBAEBCgAGBQJW6Gh7AAoJEO1sijiDR2RVwHwP+LCIydnr2DqBwblqPpuR/aqw asFjAb0xdpfXkIMsmVjErcg50QolXM0Qin1zuTUOeBo2PeBa4dvRFVg4Ew5sHzWZ +PXvoO9Cv3r8m2womIJ1yHsLEnM4jWGA+QUl/xiQ658mCvGYo9WU2qTaYo051R15 UGjeEgUkDft6s9atRicS0064bXPq+Z/cse5zidqu53TQeUmkRcFohlon3tUBQNbi FbT2emdJR1GazoaNxmMaf0m43lfAgPgnDohBxy0Mbv1Dqkk60ufF5vWyT+wza0mi iyJMjuhfT4wAfN+g5zpewKgp4faJGHyceMCn5B2JbLhGGbIehj5sBL7MKpvgPvrK adHmePDC6UkxMb4GVH82XDgUJ6Xgp5bNOUra9MmQjFUcQXl6bIhBxSjHfuelzHj8 eb+TiH6alhsTvq85oz92lbxe337btg5OW6mAUXLXvcnKtqfsBGE1c7Cd+4EuHYMO XIaetuZ1+WjvfVhPA87mlqKuQwcur4sxwS4RdEgDGrEhZfvxHZK+ClA04eg1Khhu imqSasPZOxQ4Am6Uv2+1Fkjf//I8s6sONrOIgaIWYM/P82dWfGm7Q6aP0xE2p7wq e1r93yUAHZaoC6tVy7AlnNuQlcdF+FRBPYCpebqoDBeXBxYf2R5u4MZ0MmE0KEcr ofvo/ATBV1sHwhK2EhI= =vTiu -----END PGP SIGNATURE----- --/RvYOEQaqo9O34Ko--