Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1anGgT-0004ZB-Oo for pgsql-hackers@arkaria.postgresql.org; Tue, 05 Apr 2016 02:25:37 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1anGgT-00033m-70 for pgsql-hackers@arkaria.postgresql.org; Tue, 05 Apr 2016 02:25:37 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1anGgS-00033Y-K7 for pgsql-hackers@postgresql.org; Tue, 05 Apr 2016 02:25:36 +0000 Received: from raven.toroid.org ([2a01:4f8:121:3401::2]) by makus.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1anGgP-0004G7-JB for pgsql-hackers@postgresql.org; Tue, 05 Apr 2016 02:25:35 +0000 Received: from kea.toroid.org (unknown [10.9.8.10]) by raven.toroid.org (Postfix) with ESMTP id 6764F240C688; Tue, 5 Apr 2016 04:25:31 +0200 (CEST) Received: by kea.toroid.org (Postfix, from userid 1000) id 58BF54E1610; Tue, 5 Apr 2016 07:55:30 +0530 (IST) Date: Tue, 5 Apr 2016 07:55:30 +0530 From: Abhijit Menon-Sen To: Alvaro Herrera Cc: David Steele , Robert Haas , pgsql-hackers@postgresql.org, Alexander Korotkov Subject: Re: dealing with extension dependencies that aren't quite 'e' Message-ID: <20160405022530.GA3078@toroid.org> References: <20160401123136.GA6379@toroid.org> <20160404215503.GA237481@alvherre.pgsql> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160404215503.GA237481@alvherre.pgsql> X-Pg-Spam-Score: -1.9 (-) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgsql-hackers Precedence: bulk Sender: pgsql-hackers-owner@postgresql.org At 2016-04-04 18:55:03 -0300, alvherre@2ndquadrant.com wrote: > > At this point I think we're missing user-level docs for the additional > clause in each ALTER command. Thanks for having a look. Now that you're happy with the grammar, I'll write the remaining docs and resubmit the patch later today. > Do you have any ideas on how this would appear in regression tests? No specific ideas. At a high level, I think we should install an empty extension, create one of each kind of object, alter them to depend on the extension, check that pg_depend has the right 'x' rows, then drop the extension and make sure the objects have gone away. Does that sound reasonable? Suggestions welcome. -- Abhijit -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers