Date: Mon, 27 Jun 2016 20:12:12 +0200
From: Christoph Berg <myon@debian.org>
To: PostgreSQL Hackers <pgsql-hackers@postgresql.org>,
	Tom Lane <tgl@sss.pgh.pa.us>, Andreas Karlsson <andreas@proxel.se>
Subject: Re: OpenSSL 1.1 breaks configure and more
Message-ID: <20160627181212.GA8514@msg.df7cb.de>
Mail-Followup-To: Christoph Berg <myon@debian.org>,
	PostgreSQL Hackers <pgsql-hackers@postgresql.org>,
	Tom Lane <tgl@sss.pgh.pa.us>, Andreas Karlsson <andreas@proxel.se>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="M9NhX3UHpAaciwkO"
Content-Disposition: inline
In-Reply-To: <8a0a5959-0b83-3dc8-d9e7-66ce8c1c5bc7@proxel.se>
 <1805.1467041061@sss.pgh.pa.us>
 <20160627151604.GD1051@msg.df7cb.de>
User-Agent: Mutt/1.6.0 (2016-04-01)
Precedence: bulk
Sender: pgsql-hackers-owner@postgresql.org


--M9NhX3UHpAaciwkO
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Re: Andreas Karlsson 2016-06-27 <8a0a5959-0b83-3dc8-d9e7-66ce8c1c5bc7@proxe=
l.se>
> > The errors you report make it sound like they broke API compatibility
> > wholesale.  Was that really their intent?  If so, where are the changes
> > documented?
>=20
> I do not see that they have documented the removal of the SSL_library_init
> symbol anywhere. They changed the function into a macro in the following
> commit. I guess we have to check for some other symbol, like SSL_new.

I'm not an autoconf expert, but as said in the original mail, I could
get the SSL_library_init check to work, even if that's a macro now:

> -      AC_CHECK_LIB(ssl,    SSL_library_init, [], [AC_MSG_ERROR([library =
'ssl' is required for OpenSSL])])
> +      AC_CHECK_LIB([ssl],  [SSL_library_init])

(I haven't investigated if that's due to the quoting, the removal of
the extra arguments, or simply because I reran autoreconf.)

> I think much of the above is missing from the release notes I have found.=
 I
> hope they will be more complete at the time of the release. I am working =
on
> a patch to handle these API changes.
>=20
> - https://www.openssl.org/news/openssl-1.1.0-notes.html
> - https://wiki.openssl.org/index.php/1.1_API_Changes

Nod, I was also disappointed when browsing the API changes document,
given it didn't mention any of the problems I was seeing.

Christoph

--M9NhX3UHpAaciwkO
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQIcBAEBCAAGBQJXcWx2AAoJEExaa6sS0qeuqg0QAI9R1lAr8Ce+B6pwRzsz02dB
l9Kaf07UVKSJhV9ZwHsCdw/lw2SdV5FrnQONN94Ue6OJdDRvO4lOrTuFLGc1+mUE
BgiKGS3unuY2+cAjSQYfmBquzSSwmvZyeN6kxdWRNRP6eMdk9TwQGLCMct3Sz+GE
jE+WwM+F3Bml9wQ9ccL1MrNO9PridTJ987NrYm91dkdOOnRO+ZrR4nhpw6xZ7SbV
l9H+IdU6yrX7KU9Aapgweb/bYCWmDuIxbmDkhPfmiJ0tw3tA7PjBhgxK7He9wmLV
3bdvZ2HrXgu1wIpmpWaIRw4k6AsvkASTePS6dCegU/FjpDUVQqY9hHgs5GuOHTkq
t7GVBPxJwCQ852958eFS9CfisX0CtP58auuB+zMI8isJR3Pa0Rbe+9kVY9saNQwc
2OTQ/12f42WcQNDgH46ENT7Rz6bQmh2GkjRYzXQWCS5lgiLJurzgSnO4UdAtkuV2
NmObfIcsz//WIOcUU20Ds6td4cSgfPgAgNZDzSs3fnES25GvHZwVai7A/qdyKcJO
J/vDiKGWl422N+oxTLqnMOM9YE3BV5J9BhT6PyYB3iewvBd2A83Cam0hhmnHr0l7
st0bBZ5vfmAIOZDk5aJZ6AKUCY9bufR5ysS8cS7LgsNdyamPHykLbyCecz9s1oXs
+OeEv6Mfmvqbc9UXLYqP
=Ym2p
-----END PGP SIGNATURE-----

--M9NhX3UHpAaciwkO--