Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bJJlg-0003DF-2o for pgsql-hackers@arkaria.postgresql.org; Sat, 02 Jul 2016 12:11:28 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1bJJlf-0007Ed-GY for pgsql-hackers@arkaria.postgresql.org; Sat, 02 Jul 2016 12:11:27 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1bJJlf-0007EW-1w for pgsql-hackers@postgresql.org; Sat, 02 Jul 2016 12:11:27 +0000 Received: from feynman.df7cb.de ([195.49.152.168]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1bJJlb-0003Xn-Nk for pgsql-hackers@postgresql.org; Sat, 02 Jul 2016 12:11:25 +0000 Received: from msg.df7cb.de (aftr-37-201-192-233.unity-media.net [37.201.192.233]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by feynman.df7cb.de (Postfix) with ESMTPSA id 3rhXF46ccBz3DxF; Sat, 2 Jul 2016 14:11:20 +0200 (CEST) Date: Sat, 2 Jul 2016 14:11:20 +0200 From: Christoph Berg To: Andreas Karlsson , Alvaro Herrera Cc: Tom Lane , PostgreSQL Hackers Subject: Re: OpenSSL 1.1 breaks configure and more Message-ID: <20160702121120.GC26263@msg.df7cb.de> Mail-Followup-To: Christoph Berg , Andreas Karlsson , Alvaro Herrera , Tom Lane , PostgreSQL Hackers MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160702002846.GA376611@alvherre.pgsql> User-Agent: Mutt/1.6.0 (2016-04-01) X-Pg-Spam-Score: -1.7 (-) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgsql-hackers Precedence: bulk Sender: pgsql-hackers-owner@postgresql.org Re: Andreas Karlsson 2016-07-02 > On 07/01/2016 11:41 AM, Christoph Berg wrote: > > thanks for the patches. I applied all there patches on top of HEAD > > (10c0558f). The server builds and passes "make check", pgcrypto still > > needs work, though: > > Thanks, I had forgotten pgcrypto. pgcrypto works now as well, thanks! Re: Alvaro Herrera 2016-07-02 <20160702002846.GA376611@alvherre.pgsql> > Generally, version number tests sprinkled all over the place are not > terribly nice. I think it would be better to get configure to define a > symbol like HAVE_BIO_METH_NEW. Not sure about the other hunks in this > patch; perhaps HAVE_BIO_SET_DATA, and #define both those macros if not. Otoh these symbols are strictly version-dependant on OpenSSL, it's not like one of the symbols would appear or disappear for other reasons (like different TLS implementation, or different operating system). Once we decide (in 10 years?) that the minimum supported OpenSSL version is >= 1.1, we can just drop the version checks. If these are converted to feature tests now, it will be much harder to remember at which point they can be dropped. Christoph -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers