Date: Fri, 23 Sep 2016 12:54:31 +0300
From: Aleksander Alekseev <a.alekseev@postgrespro.ru>
To: Michael Paquier <michael.paquier@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Subject: Re: [PATCH] Remove redundant if clause in standbydesc.c
Message-ID: <20160923095431.GD1238@e733>
References: <20160923090814.GB1238@e733>
 <CAB7nPqTbAXzCVDpk=jJz9R=C9ZuBsZcjN1m4-Nq4J7t3RMGOkg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: 
 <CAB7nPqTbAXzCVDpk=jJz9R=C9ZuBsZcjN1m4-Nq4J7t3RMGOkg@mail.gmail.com>
User-Agent: Mutt/1.6.1 (2016-04-27)
Precedence: bulk
Sender: pgsql-hackers-owner@postgresql.org

> > Very simple small patch - see attachment.
> 
>          /* not expected, but print something anyway */
>          else if (msg->id == SHAREDINVALRELMAP_ID)
> -            appendStringInfoString(buf, " relmap");
> -        else if (msg->id == SHAREDINVALRELMAP_ID)
>              appendStringInfo(buf, " relmap db %u", msg->rm.dbId);
> 
> Looking at inval.c, dbId can be InvalidOid.

Frankly I'm not very familiar with this part of code. InvalidOid is just
zero. Does it create some problem in this case?

-- 
Best regards,
Aleksander Alekseev


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers