Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtp (Exim 4.84_2)
	(envelope-from
 <pgsql-hackers-owner+M310697=pgsql-hackers-arkari@postgresql.org>)
	id 1c89YQ-0006mm-Jv
	for pgsql-hackers@arkaria.postgresql.org; Sat, 19 Nov 2016 17:35:54 +0000
Received: from localhost ([127.0.0.1] helo=postgresql.org)
	by malur.postgresql.org with smtp (Exim 4.84_2)
	(envelope-from
 <pgsql-hackers-owner+M310697=pgsql-hackers-arkari@postgresql.org>)
	id 1c89YQ-00084W-2N
	for pgsql-hackers@arkaria.postgresql.org; Sat, 19 Nov 2016 17:35:54 +0000
Received: from makus.postgresql.org ([2001:4800:1501:1::229])
	by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256)
	(Exim 4.84_2)
	(envelope-from <sfrost@tamriel.snowman.net>)
	id 1c89Ws-0004ON-G8
	for pgsql-hackers@postgresql.org; Sat, 19 Nov 2016 17:34:18 +0000
Received: from tamriel.snowman.net ([72.66.115.51])
	by makus.postgresql.org with esmtp (Exim 4.84_2)
	(envelope-from <sfrost@tamriel.snowman.net>)
	id 1c89Wq-0007zT-KG
	for pgsql-hackers@postgresql.org; Sat, 19 Nov 2016 17:34:17 +0000
Received: by tamriel.snowman.net (Postfix, from userid 1000)
	id 4D0E75F7AA; Sat, 19 Nov 2016 12:33:16 -0500 (EST)
Date: Sat, 19 Nov 2016 12:33:16 -0500
From: Stephen Frost <sfrost@snowman.net>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-hackers@postgresql.org
Subject: Re: pg_dump -s -b
Message-ID: <20161119173316.GA13284@tamriel.snowman.net>
References: <20161119170835.GZ13284@tamriel.snowman.net>
 <24987.1479576007@sss.pgh.pa.us>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="TOtiRR4sUKY7XQWN"
Content-Disposition: inline
In-Reply-To: <24987.1479576007@sss.pgh.pa.us>
X-Editor: Vim http://www.vim.org/
X-Info: http://www.snowman.net
X-Operating-System: Linux/3.13.0-91-generic (x86_64)
X-Uptime: 12:32:52 up 133 days, 18:57, 25 users,  load average: 0.16, 0.12,
 0.10
User-Agent: Mutt/1.5.21 (2010-09-15)
X-Pg-Spam-Score: -4.8 (----)
List-Archive: <http://archives.postgresql.org/pgsql-hackers>
List-Help: <mailto:majordomo@postgresql.org?body=help>
List-ID: <pgsql-hackers.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@postgresql.org>
List-Post: <mailto:pgsql-hackers@postgresql.org>
List-Subscribe: <mailto:majordomo@postgresql.org?body=sub%20pgsql-hackers>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>
X-Mailing-List: pgsql-hackers
Precedence: bulk
Sender: pgsql-hackers-owner@postgresql.org


--TOtiRR4sUKY7XQWN
Content-Type: multipart/mixed; boundary="84flZ2C2GPJu8SSy"
Content-Disposition: inline


--84flZ2C2GPJu8SSy
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

* Tom Lane (tgl@sss.pgh.pa.us) wrote:
> IMO, blobs are data, so those behaviors are correct.  The docs should
> be fixed to match the code.

Works for me.

Thoughts on the attached?

Thanks!

Stephen

--84flZ2C2GPJu8SSy
Content-Type: text/x-diff; charset=us-ascii
Content-Disposition: attachment; filename="pg_dump_blobs_doc_fix.patch"

diff --git a/doc/src/sgml/ref/pg_dump.sgml b/doc/src/sgml/ref/pg_dump.sgml
new file mode 100644
index 371a614..04b3124
*** a/doc/src/sgml/ref/pg_dump.sgml
--- b/doc/src/sgml/ref/pg_dump.sgml
*************** PostgreSQL documentation
*** 138,145 ****
         <para>
          Include large objects in the dump.  This is the default behavior
          except when <option>--schema</>, <option>--table</>, or
!         <option>--schema-only</> is specified, so the <option>-b</>
!         switch is only useful to add large objects to selective dumps.
         </para>
        </listitem>
       </varlistentry>
--- 138,148 ----
         <para>
          Include large objects in the dump.  This is the default behavior
          except when <option>--schema</>, <option>--table</>, or
!         <option>--schema-only</> is specified.  The <option>-b</>
!         switch is therefore only useful to add large objects to dumps
!         where a specific schema or table has been requested.  Note that
!         blobs are considered data and therefore will be included when
!         --data-only is used, but not when --schema-only is.
         </para>
        </listitem>
       </varlistentry>

--84flZ2C2GPJu8SSy--

--TOtiRR4sUKY7XQWN
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: Digital signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAEBCgAGBQJYMIzbAAoJEO1sijiDR2RV3pgQAIiGI5zee+0YIVqR0NwJowxw
J/EsfVSUtrRBh5e/jVR8wbOBrW3HkLqV0gcPl5Zr4meMbcGHT+EWLVTNKTpXnOPe
tcHAi2ZZOiB07lvszJ29g5ncN4spvxcUjIHwP1CAiQSJz5i5vNlSmDMkCOtWgUQg
e9EjPUpIx/GxJpq+iqyC0fe2/uo+ybUf2dd4aSw+Tb0FBS6P/qUb8JCVD6XwiXyu
wJG/2VJsaVj6FRn00RaHYxT18pr8CPYfeJ9KhpS8bErlFtAGs5l49nP/U1H2y04s
xjwYBOleZZmGFwpVwDTO+CS+mFL+9WZHcKOab2a6aZYG+D5clbyE7eso1yoCDFwx
l39EMGyWn+vq4ohOIgXnON14/cWug1tLId3jZX8hV+EtQs2up2zd/4BMeTYBJDQl
9648xCldcogB5N7Gd8JPfZ+xjnx7FM7AQzoRJgiCFbcS1+IykK6yUBaRamYS5Nx5
1EJJjPqDTMakJbNbchkpUfh8P2xbdHy9Hl1EHNbHeOHgGT4tCdFWzjR+HNmLdopO
G2hH1dKvbOPmNP7wK1zbgu1eUHimBYQ9k2Gt1EnXlZmPwgNaljxmluccBOzjKJFN
hUwPm5DZrNSi2uvpr/IthbegQHQwGuDyh6RLr4qfQh/N/QdRJgLkaMCAOR30y3gA
VjVGSh5uMRe311ELb+6Q
=vyRY
-----END PGP SIGNATURE-----

--TOtiRR4sUKY7XQWN--