Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c8p9S-0000gz-9w for pgsql-hackers@arkaria.postgresql.org; Mon, 21 Nov 2016 14:00:54 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1c8p9R-0005Xs-T7 for pgsql-hackers@arkaria.postgresql.org; Mon, 21 Nov 2016 14:00:53 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1c8p82-0003P0-T3 for pgsql-hackers@postgresql.org; Mon, 21 Nov 2016 13:59:27 +0000 Received: from tamriel.snowman.net ([72.66.115.51]) by makus.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c8p80-00062v-E3 for pgsql-hackers@postgresql.org; Mon, 21 Nov 2016 13:59:25 +0000 Received: by tamriel.snowman.net (Postfix, from userid 1000) id 192D45F7AE; Mon, 21 Nov 2016 08:58:24 -0500 (EST) Date: Mon, 21 Nov 2016 08:58:24 -0500 From: Stephen Frost To: Daniel Verite Cc: Rahila Syed , Ashutosh Bapat , pgsql-hackers Subject: Re: Improvements in psql hooks for variables Message-ID: <20161121135823.GJ13284@tamriel.snowman.net> References: <20161119233603.GC13284@tamriel.snowman.net> <14360f32-7d7e-4452-8fd5-e726477272b1@mm> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="Y/MuLCAROZVy4izK" Content-Disposition: inline In-Reply-To: <14360f32-7d7e-4452-8fd5-e726477272b1@mm> X-Editor: Vim http://www.vim.org/ X-Info: http://www.snowman.net X-Operating-System: Linux/3.13.0-91-generic (x86_64) X-Uptime: 08:50:51 up 135 days, 15:15, 25 users, load average: 0.64, 0.79, 0.65 User-Agent: Mutt/1.5.21 (2010-09-15) X-Pg-Spam-Score: -4.9 (----) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgsql-hackers Precedence: bulk Sender: pgsql-hackers-owner@postgresql.org --Y/MuLCAROZVy4izK Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Daniel, * Daniel Verite (daniel@manitou-mail.org) wrote: > "make check" seems OK with that, I hope it doesn't cause any regression > elsewhere. You can see what the code coverage of psql is in our current regression tests by going here: http://coverage.postgresql.org/src/bin/psql/index.html It's not exactly a pretty sight and certainly not all callers of ParseVariableBool() are covered. I'd strongly suggest you either do sufficient manual testing, or add regression tests, most likely using the tap test system (you can see an example of that in src/bin/pg_dump/t and in other 't' directories). You can generate that report after you make changes yourself using 'make coverage-html'. Thanks! Stephen --Y/MuLCAROZVy4izK Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBCgAGBQJYMv1/AAoJEO1sijiDR2RVCckP/0MSKWn4ahDQ7SVLFKG8tofH hGQTmnn3+4rGFNKihlnFHS5EdA5rcnFYAlmDiR0/Z8ggUl7so6RaIi/RdGJ5eCaY /nV9TFXQokwWvEYTOHpWBrp1ckV9Iy/uYTXFhBjASQqQdACGq2hJpjVTraP31vSf THkJi4OJ7SBwFqNlvUGKP4ApdkaIOuTvap7gpkD7Bm/rTJ42VJHZxp0o856ywMjJ krM0bjL8vlOQtR1UBN97iBa0afHfMEab1j/LEHzkDlf85sHHnKHc5WPxBdVJR9RW 6p7auBvnK6n9xc7gHlRRw7JBDJR9uOLrXat65Au/X9cug1f4himHPEovMmjvs1Xr gHX4o0a44ZKzuZHODDxLH9CUaomeMwjFxdjDV87/bBM6HgkXtnKNNDGZzRN+b2e9 AwhfKY0CKMHn2jSVIRqMvLC7jCUIc1BSszX402ls/7TCyY5zMxF/opf9uSJ/KMul QoMOqEIlp+JyAeXaJQPc8O9BlOerNycRWG5BPtvOiTzaiygjI0zYUlHjJrHbD6KJ P5HyjVrNCSREBzMyPH0A+41lVElzFrbAJWXpNccNbivbpklI5OZ7HT2r6A9toGMG fYv/oqQwJ4kroioutCYNb+scGcd25tRYLnMq55giP3T+VuUDAa/Wy6z51k51vG1/ fwoZ8hDXQIt6HRYWgFEB =ZoG4 -----END PGP SIGNATURE----- --Y/MuLCAROZVy4izK--