Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c8p91-0000fd-M6 for pgsql-hackers@arkaria.postgresql.org; Mon, 21 Nov 2016 14:00:27 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1c8p90-0004Yx-Ki for pgsql-hackers@arkaria.postgresql.org; Mon, 21 Nov 2016 14:00:26 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1c8p8z-0004XJ-Oz for pgsql-hackers@postgresql.org; Mon, 21 Nov 2016 14:00:25 +0000 Received: from tamriel.snowman.net ([72.66.115.51]) by magus.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c8p8t-0005Ja-D8 for pgsql-hackers@postgresql.org; Mon, 21 Nov 2016 14:00:25 +0000 Received: by tamriel.snowman.net (Postfix, from userid 1000) id A45635F7AF; Mon, 21 Nov 2016 08:59:18 -0500 (EST) Date: Mon, 21 Nov 2016 08:59:18 -0500 From: Stephen Frost To: Daniel Verite Cc: Tom Lane , Rahila Syed , Ashutosh Bapat , pgsql-hackers Subject: Re: Improvements in psql hooks for variables Message-ID: <20161121135918.GK13284@tamriel.snowman.net> References: <20161121134135.GF13284@tamriel.snowman.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="VGCfsDJTqEoXtsu8" Content-Disposition: inline In-Reply-To: X-Editor: Vim http://www.vim.org/ X-Info: http://www.snowman.net X-Operating-System: Linux/3.13.0-91-generic (x86_64) X-Uptime: 08:58:33 up 135 days, 15:22, 25 users, load average: 0.80, 0.66, 0.61 User-Agent: Mutt/1.5.21 (2010-09-15) X-Pg-Spam-Score: -4.9 (----) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgsql-hackers Precedence: bulk Sender: pgsql-hackers-owner@postgresql.org --VGCfsDJTqEoXtsu8 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Daniel, * Daniel Verite (daniel@manitou-mail.org) wrote: > Stephen Frost wrote: >=20 > > Are you working to make those changes? I'd rather we make the changes > > to this code once rather than push what you have now only to turn around > > and change it significantly again. >=20 > If, as a maintainer, you prefer this together in one patch, I'm fine > with that. So I'll update it shortly with changes in \timing and > a few other callers of ParseVariableBool(). Did you get a chance to review and consider the other comments from my initial review about how we might use a different approach for bools, et al? Thanks! Stephen --VGCfsDJTqEoXtsu8 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBCgAGBQJYMv22AAoJEO1sijiDR2RVC28QAIcF/MiSQlNA6C/FfqO6ZbhD EbuWWGatPShUPdTs4tCa46wZumOFpTENx8yIuRusXb88dSfiKZHhP9qjM4UIWQ7f FaPAnLjuuLAQDvFCvoNx1XEgpY3YAuW8moqhJMfNYIHMngx3h3AanN0tUab75Wn0 yL88zHP9tzdMBDNaa8vOYB5uQRf+S4K6eY0X92Vs86X9AJbZLmxRhtyjXOtNn6lV 1b31othnTVWIqm6O2bX8RVABO+5/Pdb4wQTmeQLC4NzdBqX3iB8cOVC3zT8amyhj o7VYtRwRTX1iERSYhlRLWuwfMtAFkxVRmib8QiNr3NynOPshTLYE0RGK0JslVGqR 6aSuYTinllq/QLZNczJvYNfsOMBot0JuSuib26N0o2eAxyrZkEzkSpFyL9jP85Vs L/LZIWZTBL+SO/qnIPY0yfOj75d7Stmh04DdKQciI5Ny/MFSZo46unc4fpGNv/vN ZwoHuup7P58qntj1jj/NhtbjtKfVaBhjMz2AIfXZ3JS2TAT3RdDS2Ab1ZnmEQLKV pARCPCC7Nl2sAJJspeEpqHlXuAGcbQ+ydYgOnxBEXaX5CLpjKaMYD/9/5D4GP9Vd Mf/ReEmQAwvILAI0EfwJxwsnUuGk8bZAoWcMB5/jbES+XymxPDl2K6pSJq3oWf0d cJMKssraEw5ZtLa09p4l =CtBi -----END PGP SIGNATURE----- --VGCfsDJTqEoXtsu8--