Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cJmqK-0001HV-TQ for pgsql-hackers@arkaria.postgresql.org; Wed, 21 Dec 2016 19:46:29 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1cJmqK-0004ld-Eo for pgsql-hackers@arkaria.postgresql.org; Wed, 21 Dec 2016 19:46:28 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1cJmov-00035c-HN for pgsql-hackers@postgresql.org; Wed, 21 Dec 2016 19:45:01 +0000 Received: from tamriel.snowman.net ([72.66.115.51]) by makus.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cJmoo-0007rk-Bl for pgsql-hackers@postgresql.org; Wed, 21 Dec 2016 19:45:00 +0000 Received: by tamriel.snowman.net (Postfix, from userid 1000) id 16C0F5F794; Wed, 21 Dec 2016 14:43:53 -0500 (EST) Date: Wed, 21 Dec 2016 14:43:52 -0500 From: Stephen Frost To: Tom Lane Cc: pgsql-hackers@postgresql.org Subject: Re: pg_dump vs. TRANSFORMs Message-ID: <20161221194352.GL18360@tamriel.snowman.net> References: <20160504183952.GE10850@tamriel.snowman.net> <20161207200915.GZ23417@tamriel.snowman.net> <729.1481151371@sss.pgh.pa.us> <20161208142116.GC23417@tamriel.snowman.net> <4955.1481209396@sss.pgh.pa.us> <20161208204106.GI23417@tamriel.snowman.net> <8684.1481233229@sss.pgh.pa.us> <20161208215547.GK23417@tamriel.snowman.net> <10157.1481235656@sss.pgh.pa.us> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="SvPICi00/oKz9jF1" Content-Disposition: inline In-Reply-To: <10157.1481235656@sss.pgh.pa.us> X-Editor: Vim http://www.vim.org/ X-Info: http://www.snowman.net X-Operating-System: Linux/3.13.0-91-generic (x86_64) X-Uptime: 14:43:40 up 165 days, 21:07, 36 users, load average: 0.08, 0.09, 0.13 User-Agent: Mutt/1.5.21 (2010-09-15) X-Pg-Spam-Score: -5.0 (-----) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgsql-hackers Precedence: bulk Sender: pgsql-hackers-owner@postgresql.org --SvPICi00/oKz9jF1 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable * Tom Lane (tgl@sss.pgh.pa.us) wrote: > Stephen Frost writes: > > That's a good point, we might be doing things wrong in other places in > > the code by using FirstNormalObjectId on pre-8.1 servers. >=20 > > What I suggest then is an independent patch which uses a different > > variable than FirstNormalObjectId and sets it correctly based on the > > version of database that we're connecting to, >=20 > +1 Done. Thanks! Stephen --SvPICi00/oKz9jF1 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBCgAGBQJYWtt4AAoJEO1sijiDR2RVsRoQALy4PZ8935RvrzDiU9dzQVTW tAvqywxxVjXdZ/ui9i23bXw+pC1go1P/SNZ3vHh1Bg7nrQHDff1EkYYvT8NSyDKe K/r7xbBGKiB6jXiCQLFt7UXyQu9D88ldQ50ySlNhIIo2teFho5uLq8dNauYH/SlU Zg3pxHQsh/7aNz318L5QdI7BV5N+EjFET3teloZ4ydGiUArraKCqll0xG14DoxWo /p1zKjGW2DDGnOETZnuCZq9y24QPrdrI3tOs5eXhxeYnf58DqZZqss/StMzZWj4e VwLu3PE+Z2BuSbJ+cjf+K1O/3Oka37ugA5s4sImVpefOcfm02MNQpm/+9fw45C/P GJ9ASwsish0SmihYWucLotDm/LFWXToF+6LMM/8PkOms5t+r9zZcUoaSfpCCV1nw 5XJszMgcKivv57egHaP1D2rxWDJiGPLPFKTh7WpY0R+8DiKF7QDQm8Kj22J2TZxI 5ey8kX1IlSibhoyBZlJt9vNcfNAPPUgveafKo78Z2zdAOqGdSJ+T5xBvuGrkQmuE G0boP/Y+l5bjuif4When/kiTgGIZPX8E1K3lXV9A4kQMbSsGZlJm0hMsiApsX8E5 LnFJHPx5ZOUNfYZEKdGz+rkoT0ucx2+AmfI3qlnvfxqT8V+/iwQhSyC4pXiTHYHa zscO+WlWD09KikEiGAlA =wKGo -----END PGP SIGNATURE----- --SvPICi00/oKz9jF1--