Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cLwlJ-0003Wv-Ub for pgsql-hackers@arkaria.postgresql.org; Tue, 27 Dec 2016 18:46:14 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1cLwlJ-0002Gt-EI for pgsql-hackers@arkaria.postgresql.org; Tue, 27 Dec 2016 18:46:13 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1cLwjl-0000V3-3T for pgsql-hackers@postgresql.org; Tue, 27 Dec 2016 18:44:37 +0000 Received: from tamriel.snowman.net ([72.66.115.51]) by magus.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cLwjd-0002q6-PF for pgsql-hackers@postgresql.org; Tue, 27 Dec 2016 18:44:36 +0000 Received: by tamriel.snowman.net (Postfix, from userid 1000) id 26F125F794; Tue, 27 Dec 2016 13:43:26 -0500 (EST) Date: Tue, 27 Dec 2016 13:43:26 -0500 From: Stephen Frost To: Gilles Darold Cc: pgsql-hackers@postgresql.org Subject: Re: [patch] psql tab completion for ALTER DEFAULT PRIVILEGES Message-ID: <20161227184325.GZ18360@tamriel.snowman.net> References: <1614593c-e356-5b27-6dba-66320a9bc68b@dalibo.com> <9905474c-ab29-bb66-408f-ca776fb3d69c@dalibo.com> <20161223032740.GV18360@tamriel.snowman.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="ZU25/NGocqLNwEGF" Content-Disposition: inline In-Reply-To: <20161223032740.GV18360@tamriel.snowman.net> X-Editor: Vim http://www.vim.org/ X-Info: http://www.snowman.net X-Operating-System: Linux/3.13.0-91-generic (x86_64) X-Uptime: 13:42:22 up 171 days, 20:06, 36 users, load average: 0.02, 0.06, 0.05 User-Agent: Mutt/1.5.21 (2010-09-15) X-Pg-Spam-Score: -5.0 (-----) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgsql-hackers Precedence: bulk Sender: pgsql-hackers-owner@postgresql.org --ZU25/NGocqLNwEGF Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Gilles, all, * Stephen Frost (sfrost@snowman.net) wrote: > * Gilles Darold (gilles.darold@dalibo.com) wrote: > > Added to next commitfest. To explain more this patch, the completion of > > SQL command: > >=20 > > ALTER DEFAULT PRIVILEGES FOR ROLE xxx [tab] >=20 > Here is a cleaned up patch for master and 9.6. Tomorrow I'll look into > what we can do for 9.5 and earlier, which are also wrong, but the code > is quite a bit different. Just a note that I've now fixed this and back-patched it, per discussion. I also closed it out on the commitfest app. Thanks again! Stephen --ZU25/NGocqLNwEGF Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBCgAGBQJYYrZNAAoJEO1sijiDR2RVuzkP/34faDIQD2yE0XVm3nhXy9Pe OaDtDdyIX0Yblv9ui2UcSsGwxl+kPTTtb/MYmM1vBpOV3uJPL6d+LhbE8gaQO8X3 Yz260UrKXodMbVWBr/k8KudFcaThn2FlFmaFs254eI039b837bIlrluPPTwNZxuk lzTgBeCtf8p1CmSRvuh8O/gWaO/rnq+tlfngUYjBY7WR9gnJ3VWjtX/LECvRooEL 7HQL3VX6Tngsj8QnKIYlw0mXIIrb4Xjh61JOrWxRXXNYMO5yKMGIGDUjzYcsZrYE lLYdPT0dciWZbFtN/Jv07n/Lxlrat0HqbyG56P0NH1dpcJthjHSSs5k2JoTKdX0f fmZYHmvD8156Yc4SD1gHYyWRzRu1zA4sV7HjemZuN0ai2F8Qyc8tiPnLZN16LK/D /HQ4N/L22cYbd46o3CLpJbGi+T9rdhMgRDka8X/8nWrz8cLQXtdAkaZJtKThvB+u jYru/3x4bOiDNHx6SDjIdDTtAfDr7ScdjuxcqbgVOCbGLI83gXJepPhL1/yp5b+X mQNpMgTDQahUoNoNjhNgyWDDBac5Iq5SlorkDuVa3QoddBtDRUL9ZKr3/2XBbFWW kJaxFKITnRa9KB3jEFB2u4Ufq51MSNJiz3BhVvCeuhUhn2q4XHoMfxBFKLNwK8J0 8dzHjzxUGxbc4Fg/HiLF =Fo1n -----END PGP SIGNATURE----- --ZU25/NGocqLNwEGF--