From: Tom Lane <tgl@sss.pgh.pa.us>
To: Amit Langote <amitlangote09@gmail.com>
cc: vignesh C <vignesh21@gmail.com>, Alvaro Herrera <alvherre@alvh.no-ip.org>,
        PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: on placeholder entries in view rule action query's range table
In-reply-to: <CA+HiwqH0xZOQ+GQAdKeckY1R4NOeHdzhtfxkAMJLSchpapNk5w@mail.gmail.com>
References: <CA+HiwqEf7gPN4Hn+LoZ4tP2q_Qt7n3vw7-6fJKOf92tSEnX6Gg@mail.gmail.com> <20221208091245.k2bgz7one53dulef@alvherre.pgsql> <CA+HiwqGQQzBf9ORMUwTr+J+zE-JE=1hCthTqLs4uG_z5rTLGEg@mail.gmail.com> <CA+HiwqErh+VCA+5UoqTNPV4Xou7-LQJ-hv+GNkeDiX-pbiyYAQ@mail.gmail.com> <CALDaNm1O0mF5QGi0jy2b7sitZgYmNhjQZgb_wJ-EDV2qV=sebw@mail.gmail.com> <CA+HiwqEGSopmajB9wn+swwK=gh6_Y8i8OtMsD-g4cFZ4EURA2A@mail.gmail.com> <3684848.1673211536@sss.pgh.pa.us> <CA+HiwqFp=pOfKsMkZSG+H1E-a4Jnbi5uXYxynyfi_wkWWvTK4A@mail.gmail.com> <782120.1673485582@sss.pgh.pa.us> <CA+HiwqH0xZOQ+GQAdKeckY1R4NOeHdzhtfxkAMJLSchpapNk5w@mail.gmail.com>
Comments: In-reply-to Amit Langote <amitlangote09@gmail.com>
	message dated "Wed, 05 Apr 2023 11:32:31 +0900"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <2016649.1680719613.1@sss.pgh.pa.us>
Content-Transfer-Encoding: quoted-printable
Date: Wed, 05 Apr 2023 14:33:33 -0400
Message-ID: <2016650.1680719613@sss.pgh.pa.us>
Archived-At: <https://www.postgresql.org/message-id/2016650.1680719613%40sss.pgh.pa.us>
Precedence: bulk

Amit Langote <amitlangote09@gmail.com> writes:
> While thinking about query view locking in context of [1], I realized
> that we have missed also fixing AcquirePlannerLocks() /
> ScanQueryForLocks() to consider that an RTE_SUBQUERY rte may belong to
> a view, which must be locked the same as RTE_RELATION entries.

I think you're right about that, because AcquirePlannerLocks is supposed
to reacquire whatever locks parsing+rewriting would have gotten.
However, what's with this hunk?

@@ -527,7 +527,7 @@ standard_planner(Query *parse, const char *query_strin=
g, int cursorOptions,
 	result->partPruneInfos =3D glob->partPruneInfos;
 	result->rtable =3D glob->finalrtable;
 	result->permInfos =3D glob->finalrteperminfos;
-	result->viewRelations =3D glob->viewRelations;
+	result->viewRelations =3D NIL;
 	result->resultRelations =3D glob->resultRelations;
 	result->appendRelations =3D glob->appendRelations;
 	result->subplans =3D glob->subplans;

			regards, tom lane