Date: Wed, 4 Jan 2017 10:18:50 -0500
From: Stephen Frost <sfrost@snowman.net>
To: Andreas Karlsson <andreas@proxel.se>
Cc: Magnus Hagander <magnus@hagander.net>, Tom Lane <tgl@sss.pgh.pa.us>,
	Peter Eisentraut <peter.eisentraut@2ndquadrant.com>,
	Michael Paquier <michael.paquier@gmail.com>,
	Michael Banck <michael.banck@credativ.de>,
	Peter Geoghegan <pg@heroku.com>,
	PostgreSQL-development <pgsql-hackers@postgresql.org>
Subject: Re: [PATCH] Reload SSL certificates on SIGHUP
Message-ID: <20170104151850.GQ18360@tamriel.snowman.net>
References: <16e282a4-2573-f629-09e8-e6b0ac615890@2ndquadrant.com>
 <29982.1483412575@sss.pgh.pa.us>
 <CABUevExczKi876tfqH5dY7QcMQu6v3KFBwckozD_OJr0kgVidw@mail.gmail.com>
 <23913.1483458895@sss.pgh.pa.us>
 <CABUevEzWtbL8PqcYXEagCVH_NHYQdMcXqZv4GXEeCW=kkd-J0Q@mail.gmail.com>
 <20995.1483541230@sss.pgh.pa.us>
 <CABUevExdkO3TTLYhc2oQAOWXbnz+mJ8=Tfg+WsB2P6p-_wfYyg@mail.gmail.com>
 <7fca80da-0274-3f36-eb25-d53f940c1977@proxel.se>
 <20170104151429.GP18360@tamriel.snowman.net>
 <1254e97b-a65a-5a63-e938-810507a16d71@proxel.se>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="+bngJNRfHg+qX2/U"
Content-Disposition: inline
In-Reply-To: <1254e97b-a65a-5a63-e938-810507a16d71@proxel.se>
User-Agent: Mutt/1.5.21 (2010-09-15)
Precedence: bulk
Sender: pgsql-hackers-owner@postgresql.org


--+bngJNRfHg+qX2/U
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

* Andreas Karlsson (andreas@proxel.se) wrote:
> On 01/04/2017 04:14 PM, Stephen Frost wrote:
> >* Andreas Karlsson (andreas@proxel.se) wrote:
> >>A possible solution might be to only add the error throwing hook
> >>when loading certificates during SIGHUP (and at Windows) and to work
> >>as before on startup. Would that be an acceptable solution? I could
> >>write a patch for this if people are interested.
> >
> >I'm not sure I see how that's a solution..?  Wouldn't that mean that a
> >SIGHUP with an encrypted key would result in a failure?
> >
> >The solution, at least in my view, seems to be to say "sorry, we can't
> >reload the SSL stuff if you used a passphrase to unlock the key on
> >startup, you will have to perform a restart if you want the SSL bits to
> >be changed."
>=20
> Sorry, I was very unclear. I meant refusing the reload the SSL
> context if there is a pass phrase, but that the rest of the config
> will be reloaded just fine. This will lead to some log spam on every
> SIGHUP for people with a pass phrase but should otherwise work as
> before.

Right, that sounds like it'd work for me, at least.

Thanks!

Stephen

--+bngJNRfHg+qX2/U
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: Digital signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAEBCgAGBQJYbRJaAAoJEO1sijiDR2RVebsQAIkllrmTD/UK6rdIx4D8yg56
9XLufUbrEMlOMQTUNSUoBCE2eCE+Mdq8mcmLbQpJo4liowFhMgdOTIbNksfkebKh
usj0uHxCQ32tf6oOJ2ahzHD1ETobDl9vkQx/cmbXPiq1Yb8KifS92ICxldn+bo26
gaoVvsfUc8sKRJ5l4g6WB7lWbCcLzZuM44AAAAJa3H3G6B+afkshLIMBogFbHcpM
Lp5ro/3rrc9nN0HRWfMZnKKG2n1txhpll9L/L/WmSO088qFL6N8oaHrvk/3sDPr1
s8DSPYL4+2SEC3rNTk5pGq/UnhEsgkCNlElQpvedFOga3WMEJ1hbr4Ueg7IowB1T
JaoM8dqOwZmQ8mx57Uj+MAm7qXSZxCEZ8XEYZTMpRpdasFWgH8GMMUrrvJ0jq914
1Rm2ndQ4ixblPAk4qntXujNbhuP0yvQKMOmHI/gq8qPwVvaoS71fqohG3wZB2NYA
mfQRohrpoPppeP1uRbjEbI9URzBuf21wbRtZs67ZmJ1oHIqWPFZnxKhuP6LAIgYW
N1GFgS2/jG7edHLfxwEzOTD8an4qoduStWJzfgZaClsJzkmYSOvGB7qb8kouBN1u
2jQXCqheBVNABHzgP21pLHpD6+AHqvvvUM2hcKhJPE6faYLMfLO2YSjMR3H0Zt/J
mZRoLAUoz5SEUTPnSYag
=naA0
-----END PGP SIGNATURE-----

--+bngJNRfHg+qX2/U--