Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cQoND-0006Ag-5f for pgsql-hackers@arkaria.postgresql.org; Tue, 10 Jan 2017 04:49:27 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1cQoNB-0000Cf-WC for pgsql-hackers@arkaria.postgresql.org; Tue, 10 Jan 2017 04:49:26 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1cQoNA-0000CW-Bq for pgsql-hackers@postgresql.org; Tue, 10 Jan 2017 04:49:24 +0000 Received: from tamriel.snowman.net ([72.66.115.51]) by magus.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cQoN3-0000ab-3z for pgsql-hackers@postgresql.org; Tue, 10 Jan 2017 04:49:23 +0000 Received: by tamriel.snowman.net (Postfix, from userid 1000) id 16BC75F794; Mon, 9 Jan 2017 23:48:16 -0500 (EST) Date: Mon, 9 Jan 2017 23:48:16 -0500 From: Stephen Frost To: pgsql-hackers@postgresql.org Subject: pg_restore accepts -j -1 Message-ID: <20170110044815.GC18360@tamriel.snowman.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="Z/W+H++SBmO57jII" Content-Disposition: inline X-Editor: Vim http://www.vim.org/ X-Info: http://www.snowman.net X-Operating-System: Linux/3.13.0-91-generic (x86_64) X-Uptime: 23:42:11 up 185 days, 6:06, 37 users, load average: 0.14, 0.10, 0.06 User-Agent: Mutt/1.5.21 (2010-09-15) X-Pg-Spam-Score: -5.1 (-----) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgsql-hackers Precedence: bulk Sender: pgsql-hackers-owner@postgresql.org --Z/W+H++SBmO57jII Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Greetings, For reasons which seem likely to be entirely unintentional, pg_restore will accept a '-1' for -j: pg_restore -j -1 This seems to result in the parallel state being NULL and so things don't outright break, but it hardly seems likely to be what the user was asking for- my guess is that they actually wanted "parallel, single transaction", which we don't actually support: -> pg_restore -j 2 -1 pg_restore: cannot specify both --single-transaction and multiple jobs We also don't accept -1 for pg_dump: -> pg_dump -j -1 pg_dump: invalid number of parallel jobs If I'm missing something, please let me know, otherwise I'll plan to put the same check into pg_restore which exists in pg_dump. Thanks! Stephen --Z/W+H++SBmO57jII Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBCgAGBQJYdGePAAoJEO1sijiDR2RVULsP/0HhTnXcASKh+NCn4U7vuH4h g8/7kJPAjLDOh8htUmkt4IcdjyEOieU8Rld8l5QgGzsYjxwrY8duGjKGrT1/wfdO TINmtwTIMrw8ttlO9WLqPOIDob9Z4ZtejHUReuu6T1vIEJOtgn/3PhcBJ4+Wk8Q3 2UzYdZ8sN6qk7412/4rabhaCjFNf8RWIze1m1/e4aLnsN0912dWfQ9VGWmofrz34 w1mXTiSnQDHQO2vrvrOX+YylRDia3vpQlFEljTiKK+pSHlV6aBsu1P3b5cfkV2Dj 4LMGpXlIGoKcXTYVaDTzhsuLSiISU3wWH5SwHyUHh53USg5KYopTXGiIygzQVjnh 2dUrOI3OsMTJRzgXJsWf2LyhyJLM+2/Tu1KAGpT/e341liMDWFtAsgf5QEjHMcQ5 2yxyCDGsSWLRrhJ7m7icWTRr15R2Et171b+SagVV3RrO5oOCdO5Im/cWTOalyvr/ doPjYvsIpWsppComYp5QcJ8Q733p7GkxwMZwkZiTC9OhawPOThqjnXH585l64l8w i+TmyfNwjj/kje7STjaObirDKJDke4ie+w9qdo3iwmcpVlsu+TvZlfylNT5VsC91 Q0evRd8k0oRCkidh66d2LmPo0P8bjTyygYb+rsZu7+CUG9YOfs+/KpPhSNEBvpxW 1X5WzAD0DLRMbYk8OBLt =FmCc -----END PGP SIGNATURE----- --Z/W+H++SBmO57jII--