Date: Wed, 11 Jan 2017 11:21:35 -0300
From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Jesper Pedersen <jesper.pedersen@redhat.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, Ashutosh Sharma <ashu.coek88@gmail.com>,
	Robert Haas <robertmhaas@gmail.com>,
	Peter Eisentraut <peter.eisentraut@2ndquadrant.com>,
	Michael Paquier <michael.paquier@gmail.com>,
	Jeff Janes <jeff.janes@gmail.com>,
	PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Subject: Re: pageinspect: Hash index support
Message-ID: <20170111142135.7zgo3vxaml5k4uwt@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <59ce3337-075d-d8ee-fe33-280a4cc0700a@redhat.com>
User-Agent: NeoMutt/20161104 (1.7.1)
Precedence: bulk
Sender: pgsql-hackers-owner@postgresql.org

Jesper Pedersen wrote:

> +		/*
> +		 * We copy the page into local storage to avoid holding pin on the
> +		 * buffer longer than we must, and possibly failing to release it at
> +		 * all if the calling query doesn't fetch all rows.
> +		 */
> +		mctx = MemoryContextSwitchTo(fctx->multi_call_memory_ctx);
> +
> +		uargs = palloc(sizeof(struct user_args));
> +
> +		uargs->page = palloc(BLCKSZ);

Is this necessary?  I think this was copied from btreefuncs, but there
is no buffer release in this code.

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers