Date: Wed, 18 Jan 2017 13:47:02 -0800
From: Andres Freund <andres@anarazel.de>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Robert Haas <robertmhaas@gmail.com>,
	"pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
Subject: Re: Implement targetlist SRFs using ROWS FROM() (was
 Changed SRF in targetlist handling)
Message-ID: <20170118214702.54b2mdbxce5piwv5@alap3.anarazel.de>
References: <32021.1484678618@sss.pgh.pa.us>
 <20170117185346.z55d3jnsaf24yr4m@alap3.anarazel.de>
 <837.1484680521@sss.pgh.pa.us>
 <12780.1484747004@sss.pgh.pa.us>
 <20170118191924.25lfp6rd6y3kw5sa@alap3.anarazel.de>
 <13690.1484767452@sss.pgh.pa.us>
 <20170118193420.znochutmnzusd636@alap3.anarazel.de>
 <15814.1484769612@sss.pgh.pa.us>
 <460325A6-EF35-4A29-A1A0-EEDC3EDCF750@anarazel.de>
 <22709.1484771072@sss.pgh.pa.us>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <22709.1484771072@sss.pgh.pa.us>
Precedence: bulk
Sender: pgsql-hackers-owner@postgresql.org

Hi,

On 2017-01-18 15:24:32 -0500, Tom Lane wrote:
> Andres Freund <andres@anarazel.de> writes:
> > Yea, have something lying around.  Let me push it then when I get back from lunch?
> 
> Sure, no sweat.

Pushed.  Yay!

There's one sgml comment you'd added:
"Furthermore, nested set-returning functions did not work at all."

I'm not quite sure what you're referring to there - it was previously
allowed to have one set argument to an SRF:

postgres[28758][1]=# SELECT generate_series(1,generate_series(1,5));
┌─────────────────┐
│ generate_series │
├─────────────────┤
│               1 │
│               1 │
│               2 │
│               1 │
│               2 │
│               3 │


Am I misunderstanding what you meant?  I left it in what I committed,
but we probably should clear up the language there.


Working on rebasing the cleanup patch now.  Interested in reviewing
that?  Otherwise I think I'll just push the rebased version of what I'd
posted before, after making another pass through it.


- Andres


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers