Date: Tue, 31 Jan 2017 13:55:38 -0800
From: Andres Freund <andres@anarazel.de>
To: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: Pavan Deolasee <pavan.deolasee@gmail.com>,
	Jaime Casanova <jaime.casanova@2ndquadrant.com>,
	Haribabu Kommi <kommi.haribabu@gmail.com>,
	Tomas Vondra <tomas.vondra@2ndquadrant.com>,
	pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: Patch: Write Amplification Reduction Method (WARM)
Message-ID: <20170131215538.5c65rexachourokl@alap3.anarazel.de>
References: 
 <CABOikdNU0qhKE-65x59qaj2kL-Jpq73Ri95ZODAvxxhsEBN9LQ@mail.gmail.com>
 <20170131171001.wg7bc4pimfu6in6t@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20170131171001.wg7bc4pimfu6in6t@alvherre.pgsql>
Precedence: bulk
Sender: pgsql-hackers-owner@postgresql.org

On 2017-01-31 14:10:01 -0300, Alvaro Herrera wrote:
> Pavan Deolasee wrote:
> 
> > Two new APIs added.
> > 
> > - CatalogInsertHeapAndIndex which does a simple_heap_insert followed by
> > catalog updates
> > - CatalogUpdateHeapAndIndex which does a simple_heap_update followed by
> > catalog updates
> > 
> > There are only a handful callers remain for simple_heap_insert/update after
> > this patch. They are typically working with already opened indexes and
> > hence I left them unchanged.
> 
> Hmm, I was thinking we would get rid of CatalogUpdateIndexes altogether.
> Two of the callers are in the new routines (which I propose to rename to
> CatalogTupleInsert and CatalogTupleUpdate); the only remaining one is in
> InsertPgAttributeTuple.  I propose that we inline the three lines into
> all those places and just remove CatalogUpdateIndexes.  Half the out-of-
> core places that are using this function will be broken as soon as WARM
> lands anyway.  I see no reason to keep it.  (I have already modified the
> patch this way -- no need to resend).
> 
> Unless there are objections I will push this later this afternoon.

Hm, sorry for missing this earlier.  I think CatalogUpdateIndexes() is
fairly widely used in extensions - it seems like a pretty harsh change
to not leave some backward compatibility layer in place.

Andres


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers