Date: Tue, 31 Jan 2017 17:24:17 -0500
From: Stephen Frost <sfrost@snowman.net>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Andres Freund <andres@anarazel.de>,
	Alvaro Herrera <alvherre@2ndquadrant.com>,
	Pavan Deolasee <pavan.deolasee@gmail.com>,
	Jaime Casanova <jaime.casanova@2ndquadrant.com>,
	Haribabu Kommi <kommi.haribabu@gmail.com>,
	Tomas Vondra <tomas.vondra@2ndquadrant.com>,
	pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: Patch: Write Amplification Reduction Method (WARM)
Message-ID: <20170131222416.GS9812@tamriel.snowman.net>
References: 
 <CABOikdNU0qhKE-65x59qaj2kL-Jpq73Ri95ZODAvxxhsEBN9LQ@mail.gmail.com>
 <20170131171001.wg7bc4pimfu6in6t@alvherre.pgsql>
 <20170131215538.5c65rexachourokl@alap3.anarazel.de>
 <32115.1485901288@sss.pgh.pa.us>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="MvjEjs9xyVvypSOG"
Content-Disposition: inline
In-Reply-To: <32115.1485901288@sss.pgh.pa.us>
User-Agent: Mutt/1.5.21 (2010-09-15)
Precedence: bulk
Sender: pgsql-hackers-owner@postgresql.org


--MvjEjs9xyVvypSOG
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

* Tom Lane (tgl@sss.pgh.pa.us) wrote:
> Andres Freund <andres@anarazel.de> writes:
> > Hm, sorry for missing this earlier.  I think CatalogUpdateIndexes() is
> > fairly widely used in extensions - it seems like a pretty harsh change
> > to not leave some backward compatibility layer in place.
>=20
> If an extension is doing that, it is probably constructing tuples to put
> into the catalog, which means it'd be equally (and much more quietly)
> broken by any change to the catalog's schema.  We've never considered
> such an argument as a reason not to change catalog schemas, though.
>=20
> In short, I've got mighty little sympathy for that argument.

+1

> (I'm a little more concerned by Alvaro's apparent position that WARM
> is a done deal; I didn't think so.  This particular change seems like
> good cleanup anyhow, however.)

Agreed.

Thanks!

Stephen

--MvjEjs9xyVvypSOG
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: Digital signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAEBCgAGBQJYkQ6QAAoJEO1sijiDR2RVNDEQAJc/Ley3zvP/9JRtAWWtyxGh
Nqfahxh2C+SYy78cGv4Zu+kWU6uAR52gSjAsgMIFCR56rWUtqGV6qIhQfE3h5LJU
MlMW3AOcet/melJPzG0oDDm6n0iKBGY8raKQJiSXoGAlcd/7u94GXhf/BZadSh91
nd7jQ+ifyNr+O9YBMnfBHVMgoWRm7a8T/lrGcWdaQexwNt4Xa7+Mj5ixQzMZ12ym
Ef+KjztjkuNtYRMSrQuWYLqtneGYKZ+J0wDMGmCpNtjQohqHxrkUiWYafiRFvGhW
ejZf9T8XCdf0ClITMentYWUeuwVH/vxDMEfVFLDFzIRU9KFzT5/FDTQuleysQN2Z
hwqbEh8tb63fZu9yEp1s6xFKR1NkxUxxsBiredulNOQWYMfv9IzlWntrPLQAaKYY
rqwBPsu2VX0w5ePq4jMpAgqeRU8r+m3Ii6g52iB0T9gUHUtrO/vIidMMN681M3bO
muc3aqNyqsD/Kp2mPh/PU2Ui/q1c20GNL1I9NAdiu+cbCJprcRyZ2rac4wPzi+4m
RoojvkTtz7BSzT6L3PZYSgarFgycyzC/altw6s/nKwQd/r1FYmo+qiq7xy+jy5Qy
Dte50rOcuqkOlodwHRvR93rxS/V/WOYvJD67B2Hr+aigkhQIIltuRPJEIbvTqFzZ
x1kfT0NI0RJSRkjnlHVw
=Zdjz
-----END PGP SIGNATURE-----

--MvjEjs9xyVvypSOG--