Date: Fri, 17 Feb 2017 15:13:48 -0300
From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Thomas Munro <thomas.munro@enterprisedb.com>,
	Pg Hackers <pgsql-hackers@postgresql.org>,
	Andrew Dunstan <andrew@dunslane.net>
Subject: Re: pg_recvlogical.c doesn't build with
 --disable-integer-datetimes
Message-ID: <20170217181348.a5pnflupslw2t6xx@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <29306.1487352105@sss.pgh.pa.us>
User-Agent: NeoMutt/20170206-195-7adf12 (1.7.2)
Precedence: bulk
Sender: pgsql-hackers-owner@postgresql.org

Tom Lane wrote:

> My own compilers don't generate errors either, only warnings.  Maybe
> we could catch this sort of thing mechanically with a critter configured
> with -Werror as well as --disable-integer-datetimes, but I'm a tad
> hesitant to have a buildfarm machine configured with -Werror.  We'd
> be raising the stakes quite a bit on keeping the code warning-free
> for a specific compiler that might prove to be picky in silly ways.
> 
> But if it were a pretty mainstream compiler that hadn't shown much
> evidence of wanting to throw useless warnings, maybe that's fine.
> 
> Thoughts?

Note that Thomas' compiler was using -Werror.

I think we're at a point where one gcc plus one clang animals set up
with -Werror would be a good thing to have, and keep green.  In
practice, this list fulfills the role of such a compiler, only with much
higher communication overhead.

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers