Date: Mon, 20 Feb 2017 17:38:05 -0500
From: Bruce Momjian <bruce@momjian.us>
To: Peter Geoghegan <pg@bowt.ie>
Cc: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>,
	Thomas Munro <thomas.munro@enterprisedb.com>,
	pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: ICU integration
Message-ID: <20170220223805.GD2672@momjian.us>
References: <85364fde-091f-bbc0-fec2-e3ede39840a6@2ndquadrant.com>
 <3a88fa29-275b-f547-9957-86d4b2cd68db@2ndquadrant.com>
 <CAM3SWZT6YFtkkjUOGgzBV9_tMijz+s68YgDZi7Qc2sPdFnQ9Bw@mail.gmail.com>
 <CAEepm=3W4kUoAMYG3XOKPqv-=k1TL5A8zJvF6M93DNaHRoQeyw@mail.gmail.com>
 <c288b52e-2b83-8c0c-0f99-b34531763a5a@2ndquadrant.com>
 <CAH2-Wz=oLbhixpkMC1be+y6f7RydD2xE8Nw4UMOUpTsagN9mxA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: 
 <CAH2-Wz=oLbhixpkMC1be+y6f7RydD2xE8Nw4UMOUpTsagN9mxA@mail.gmail.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Precedence: bulk
Sender: pgsql-hackers-owner@postgresql.org

On Wed, Feb 15, 2017 at 10:35:34PM -0800, Peter Geoghegan wrote:
> On Wed, Feb 15, 2017 at 9:17 PM, Peter Eisentraut
> <peter.eisentraut@2ndquadrant.com> wrote:
> > Stable operating systems shouldn't do major library upgrades, so I feel
> > pretty confident about this.
> 
> There is one case where it *is* appropriate for a bugfix release of
> ICU to bump collator version: When there was a bug in the collator
> itself, leading to broken binary blobs [1]. We should make the user
> REINDEX when this happens.
> 
> I think that ICU may well do this in point releases, which is actually
> a good thing. So, it seems like a good idea to test that there is no
> change, in a place like check_strxfrm_bug(). In my opinion, we should
> LOG a complaint in the event of a mismatch rather than refusing to
> start the server, since there probably isn't that much chance of the
> user being harmed by the bug. The cost of not starting the server
> properly until a REINDEX finishes or similar looks particularly
> unappealing when one considers that the app was probably affected by
> any corruption for weeks or months before the ICU update enabled its
> detection.
> http://www.postgresql.org/mailpref/pgsql-hackers

I can't think of any cases where we warn of possible corruption only in
the server logs.

-- 
  Bruce Momjian  <bruce@momjian.us>        http://momjian.us
  EnterpriseDB                             http://enterprisedb.com

+ As you are, so once was I.  As I am, so you will be. +
+                      Ancient Roman grave inscription +


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers