Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ciWru-00078e-HJ for pgsql-hackers@arkaria.postgresql.org; Tue, 28 Feb 2017 01:46:22 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1ciWru-0007Id-3r for pgsql-hackers@arkaria.postgresql.org; Tue, 28 Feb 2017 01:46:22 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1ciWqO-0004Zh-PN for pgsql-hackers@postgresql.org; Tue, 28 Feb 2017 01:44:48 +0000 Received: from momjian.us ([72.94.173.45]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1ciWqI-0006Un-Kc for pgsql-hackers@postgresql.org; Tue, 28 Feb 2017 01:44:48 +0000 Received: from bruce by momjian.us with local (Exim 4.84_2) (envelope-from ) id 1ciWqG-0005NB-R1; Mon, 27 Feb 2017 20:44:40 -0500 Date: Mon, 27 Feb 2017 20:44:40 -0500 From: Bruce Momjian To: Stephen Frost Cc: pgsql-hackers@postgresql.org Subject: Re: pg_upgrade loses security lables and COMMENTs on blobs Message-ID: <20170228014440.GD11339@momjian.us> References: <20170221162655.GE9812@tamriel.snowman.net> <20170223153637.GV9812@tamriel.snowman.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170223153637.GV9812@tamriel.snowman.net> User-Agent: Mutt/1.5.23 (2014-03-12) X-Pg-Spam-Score: -1.9 (-) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgsql-hackers Precedence: bulk Sender: pgsql-hackers-owner@postgresql.org On Thu, Feb 23, 2017 at 10:36:37AM -0500, Stephen Frost wrote: > All, > > * Stephen Frost (sfrost@snowman.net) wrote: > > Just wanted to get a note out to -hackers about the issue, I'll see > > about getting a fix written up for it soon. > > Attached is a patch which addresses this issue. I'm not terribly > pleased with it, but I also haven't got any great ideas of what else to > do. Suggestions welcome, of course. > > Otherwise, I'll plan to start working on the back-branch changes for > this soon. Yeah, this is probably the best you can do. Your analysis of how we used to treat large objects is correct, and was never adjusted for the changes you outlined. -- Bruce Momjian http://momjian.us EnterpriseDB http://enterprisedb.com + As you are, so once was I. As I am, so you will be. + + Ancient Roman grave inscription + -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers