Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cjK6w-0003vJ-V8 for pgsql-hackers@arkaria.postgresql.org; Thu, 02 Mar 2017 06:21:11 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1cjK6w-0006WR-Gn for pgsql-hackers@arkaria.postgresql.org; Thu, 02 Mar 2017 06:21:10 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1cjK5Q-000317-A5 for pgsql-hackers@postgresql.org; Thu, 02 Mar 2017 06:19:36 +0000 Received: from out4-smtp.messagingengine.com ([66.111.4.28]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1cjK5N-0006FU-Dy for pgsql-hackers@postgresql.org; Thu, 02 Mar 2017 06:19:35 +0000 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 37E40209ED; Thu, 2 Mar 2017 01:19:32 -0500 (EST) Received: from frontend1 ([10.202.2.160]) by compute5.internal (MEProxy); Thu, 02 Mar 2017 01:19:32 -0500 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc:x-sasl-enc; s=smtpout; bh=wxVpU9mRrUpaJ6 gmfyh7neKcT2M=; b=gTdanjOwIofjTGc819povsFhgrGZ1zkwjwtcqKdrsKO48D xoiV2BbD9lrV073LKHLE8xV1qFPkvxCKoF4VfBGHDpv63HCwJo1oLBf7HXCRbOsk wLDn06pWgT8mZFH9rqSDN9z3yfsUSAAC07asZalGrFT61S5ADH1slIhPXppFs= X-ME-Sender: X-Sasl-enc: qUKRmyMa1eNVhEjFqyUiYqutsqn5pPdJIgqANpxSnofm 1488435571 Received: from intern.anarazel.de (unknown [199.87.86.247]) by mail.messagingengine.com (Postfix) with ESMTPA id E1DAE7E0D2; Thu, 2 Mar 2017 01:19:31 -0500 (EST) Date: Wed, 1 Mar 2017 22:19:30 -0800 From: Andres Freund To: Tomas Vondra Cc: Tom Lane , Petr Jelinek , Petr Jelinek , Robert Haas , John Gorman , pgsql-hackers Subject: Re: PATCH: two slab-like memory allocators Message-ID: <20170302061930.ofjfbecdbdchn76s@alap3.anarazel.de> References: <20170227174201.yrofai7neyp6shb2@alap3.anarazel.de> <20170228034232.4h7ouyhxq4lbbao2@alap3.anarazel.de> <1240.1488254244@sss.pgh.pa.us> <20170228051630.3qcevakcaaa6b4ef@alap3.anarazel.de> <1671.1488259784@sss.pgh.pa.us> <20170228074420.aazv4iw6k562mnxg@alap3.anarazel.de> <20170228184122.extbigaer5ryrt3z@alap3.anarazel.de> <20170301041835.wli3viwnxr5wonfv@alap3.anarazel.de> <11adca69-be28-44bc-a801-64e6d53851e3@2ndquadrant.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <11adca69-be28-44bc-a801-64e6d53851e3@2ndquadrant.com> X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgsql-hackers Precedence: bulk Sender: pgsql-hackers-owner@postgresql.org On 2017-03-02 04:36:23 +0100, Tomas Vondra wrote: > I've noticed two minor typos: > > 1) That is solved this by creating ... > - extra "this" > > 2) Given this, routines like pfree their corresponding context ... > - missing "find" or "determine" Will fix. > I also see you've explicitly mentioned the callbacks were added in 9.5. > Doesn't that somewhat reintroduce the historical account? That section I just moved up, the version reference was there before. I left it in, because it seemed new enough to still be somewhat relevant; removed and added it, not sure what's better. Greetings, Andres Freund -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers