Date: Fri, 3 Mar 2017 10:08:18 -0500
From: Stephen Frost <sfrost@snowman.net>
To: Bruce Momjian <bruce@momjian.us>
Cc: pgsql-hackers@postgresql.org
Subject: Re: pg_upgrade loses security lables and COMMENTs on blobs
Message-ID: <20170303150818.GR9812@tamriel.snowman.net>
References: <20170221162655.GE9812@tamriel.snowman.net>
 <20170223153637.GV9812@tamriel.snowman.net>
 <20170228014440.GD11339@momjian.us>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="1grANIhBTcW9M18L"
Content-Disposition: inline
In-Reply-To: <20170228014440.GD11339@momjian.us>
User-Agent: Mutt/1.5.21 (2010-09-15)
Precedence: bulk
Sender: pgsql-hackers-owner@postgresql.org


--1grANIhBTcW9M18L
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Bruce,

* Bruce Momjian (bruce@momjian.us) wrote:
> On Thu, Feb 23, 2017 at 10:36:37AM -0500, Stephen Frost wrote:
> > * Stephen Frost (sfrost@snowman.net) wrote:
> > > Just wanted to get a note out to -hackers about the issue, I'll see
> > > about getting a fix written up for it soon.
> >=20
> > Attached is a patch which addresses this issue.  I'm not terribly
> > pleased with it, but I also haven't got any great ideas of what else to
> > do.  Suggestions welcome, of course.
> >=20
> > Otherwise, I'll plan to start working on the back-branch changes for
> > this soon.
>=20
> Yeah, this is probably the best you can do.   Your analysis of how we
> used to treat large objects is correct, and was never adjusted for the
> changes you outlined.

Great, thanks, I'll be pushing this to all the branches soon, still
testing.

Thanks again!

Stephen

--1grANIhBTcW9M18L
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: Digital signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAEBCgAGBQJYuYbiAAoJEO1sijiDR2RV16wQAMEynXs+NBEyn5m1Io8EEnO8
n71SwLaZjfdO2G4I8maY84R/3lOUbPYu8/dfcglmhFnUqlDvb+SRWn2SlqzmGcuA
NruocfwGNstrSLxs7vqJPeyULRutA+pYBl+hzGFCULHzWov7FdPYt4Rz1K1pGEM+
ndL2LRF510SB+Hc5mIumcV0DxrnMNTiXbQ4OaQFJhLm5R2SOXQmJ3p71JIf7b7I2
gT9XbUdTLMit05hzuHW90Prd3ZMRgpcXxTjVitB5yJ+SQO9bY86kzRTg0HQqFwaN
zjL1GdOkN8TssbpKlI9csQZZUJNOKaxl+cDUAJvbNr3UgkSTNF/IsinACI01vfTW
cviW8FBOg1UijgjMTex6kGl5BaazKxAW/akscE/K1fkm0Sb9Obh7QtECBVdW6inw
/m5V2/o7pi8mRsCfTrm1Ba1KNhdfzkvZwSgLQfFBAljaEKkLRaI0icYIg6UuSItP
Ar8XKCwsFmhvybka7YSuRvuvMT0bcIN39XNIQOpdY466XIiFSJVq8aF4VImDYENx
S2B1+VZmBgsgHbc6B00JAaYaEYBKwVZmze30rnFtCNr1cLI111IsegjnvER7Cbnd
Rj6tM3tLJ6dobOJv3CezQZOV3BhlZqUctG63BwY1L0HwFiRaF/V6MnclpiaXIBpo
+A2kOxtG8O97E0t6iHKB
=bS6m
-----END PGP SIGNATURE-----

--1grANIhBTcW9M18L--