Date: Mon, 6 Mar 2017 09:33:43 +0100
From: Michael Banck <michael.banck@credativ.de>
To: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Cc: Jim Nasby <Jim.Nasby@BlueTreble.com>,
	Pg Hackers <pgsql-hackers@postgresql.org>
Subject: Re: Change in "policy" on dump ordering?
Message-ID: <20170306083342.GA8374@nighthawk.caipicrew.dd-dns.de>
References: <87866740-ef55-8a6d-6480-499b92aa23c0@BlueTreble.com>
 <8f64786e-824d-7c0d-33a6-3d9e1c8e9fde@2ndquadrant.com>
 <edc1dc0d-66ba-0d9e-b0e7-890f064789d7@BlueTreble.com>
 <33b25c65-94f1-6ff6-c717-61a56294a255@2ndquadrant.com>
 <a537995b-ccdb-f668-5f67-98e9b9b4a99d@BlueTreble.com>
 <75409fb1-bd96-25c2-f6b0-c24e28ed2684@2ndquadrant.com>
 <65049c27-96bf-317b-b435-931f6041f94c@BlueTreble.com>
 <67d35333-ef65-074a-b2be-52440f245e43@2ndquadrant.com>
 <753dcafc-a648-9041-e9ca-e405cd4498f4@2ndquadrant.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <753dcafc-a648-9041-e9ca-e405cd4498f4@2ndquadrant.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Precedence: bulk
Sender: pgsql-hackers-owner@postgresql.org

Hi,

On Sat, Mar 04, 2017 at 02:49:36PM -0500, Peter Eisentraut wrote:
> On 3/1/17 08:36, Peter Eisentraut wrote:
> > On 2/22/17 18:24, Jim Nasby wrote:
> >>> Yes, by that logic matview refresh should always be last.
> >>
> >> Patches for head attached.
> >>
> >> RLS was the first item added after DO_REFRESH_MATVIEW, which was added 
> >> in 9.5. So if we want to treat this as a bug, they'd need to be patched 
> >> as well, which is a simple matter of swapping 33 and 34.
> > 
> > I wonder whether we should emphasize this change by assigning
> > DO_REFRESH_MATVIEW a higher number, like 100?
> 
> Since there wasn't any interest in that idea, I have committed Jim's
> patch as is.

Would this be a candidate for backpatching, or is the behaviour change
in pg_dump trumping the issues it solves?


Michael

-- 
Michael Banck
Projektleiter / Senior Berater
Tel.: +49 2166 9901-171
Fax:  +49 2166 9901-100
Email: michael.banck@credativ.de

credativ GmbH, HRB Mönchengladbach 12080
USt-ID-Nummer: DE204566209
Trompeterallee 108, 41189 Mönchengladbach
Geschäftsführung: Dr. Michael Meskes, Jörg Folz, Sascha Heuer


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers