Date: Thu, 9 Mar 2017 09:15:31 -0500
From: Stephen Frost <sfrost@snowman.net>
To: pgsql-hackers@postgresql.org
Subject: postgres_fdw IMPORT SCHEMA and partitioned tables
Message-ID: <20170309141531.GD9812@tamriel.snowman.net>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="HShZ9mKAOB5hSJfb"
Content-Disposition: inline
User-Agent: Mutt/1.5.21 (2010-09-15)
Precedence: bulk
Sender: pgsql-hackers-owner@postgresql.org


--HShZ9mKAOB5hSJfb
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

Greetings,

While reviewing Amit Langote's patch to handle partitioned tables
properly in various contrib modules (mostly by throwing an error since
things like pageinspect aren't going to work on the empty 'parent'
table), I went looking through contrib for other modules that do
something with relkind and noticed that postgres_fdw's IMPORT SCHEMA
would pull in the child tables (relkind = 'r') but would ignore the
parent table (relkind = 'P', or soon to be 'p', I guess).

I tend to view this as an issue which should be added to the open items
list and resolved before PG10 (though perhaps it could be done after
feature freeze), but I could see an argument that it should be just a
documented limitation of postgres_fdw and that adding such support would
be a new feature.

In any case, this seems like an issue that should be addressed one way
or the other, so I'll add it to the open items list.  I'm not planning
to work on fixing it myself, but if someone proposes a patch which looks
reasonable, I'll try to find time for it.

Thanks!

Stephen

--HShZ9mKAOB5hSJfb
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: Digital signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAEBCgAGBQJYwWODAAoJEO1sijiDR2RVAMAP/iM9N349BqzNOewwO9Bwc6GG
XsC815bK15jW6iV7XYDNUGzhox1T2bbJ+2dWYAybgAyGE0+0tqwkNXhQqjBlAr0z
+8jnGtxQWaHbQBqqCbuffqmqHFE8DQ8XT2s/ObP5VVSXkOcrs6WyhY7KoLqWTaW1
ciQ2LU06M9nGnkqE7Vb59Abjjhey/6Gkf4hJlWpb6Z1gkaHIvThSK4EFgrEa0mg1
nkrJ4ASJI/ZNv7ZLPrAzR42Z/umVVAFHtRQzOV/W6Whe3ZeEL3gV1Sks87IxjBjY
AmUXqgjUacZ6TLyML2Ycl+sOMdec5hIUlG+k4d+IzsPg3CcVPsYCXX4dbLyhhyX/
apBajqEkqXk9bfcNIklVPTlNiiP3zvYYZG0l2lBFTFVrsVmjzZooazd7RSPOSSAQ
RyHk6YECU9vaD0QIofgFS5iw4YtbeHvxLps3TiN6dWe9SFHs8AoOpsUStll3oxx+
JFltXCWnBIyW/NBtrKxU3+aw2E1ZPykzEueIHOpY38fV8J+lSflM1/OExhr3K7mz
0BnI6FWiDtdcNZUOfGSf5x0defoIqXMZmaOcL0zEqbnYpjao/GU79PFnkfW22NmW
XR7ZTL9QylJ0eX9fegx/e59oRKmb4YCmUDYGgY+odC+YMpSUOHKNjQCN5F/Infa5
/IJqjDHKYfWTsWu9Ahvg
=5F6t
-----END PGP SIGNATURE-----

--HShZ9mKAOB5hSJfb--