Date: Mon, 20 Mar 2017 12:40:58 -0400
From: Stephen Frost <sfrost@snowman.net>
To: Amit Langote <Langote_Amit_f8@lab.ntt.co.jp>
Cc: Pg Hackers <pgsql-hackers@postgresql.org>
Subject: Re: pg_dump emits ALTER TABLE ONLY partitioned_table
Message-ID: <20170320164058.GT9812@tamriel.snowman.net>
References: <7682253a-6f79-6a92-00aa-267c4c412870@lab.ntt.co.jp>
 <20170217133251.GK9812@tamriel.snowman.net>
 <2509e5e9-4de2-1846-ddd0-6964f81d6c8b@lab.ntt.co.jp>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="7155Inxk/SN6GkBE"
Content-Disposition: inline
In-Reply-To: <2509e5e9-4de2-1846-ddd0-6964f81d6c8b@lab.ntt.co.jp>
User-Agent: Mutt/1.5.21 (2010-09-15)
Precedence: bulk
Sender: pgsql-hackers-owner@postgresql.org


--7155Inxk/SN6GkBE
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Amit,

* Amit Langote (Langote_Amit_f8@lab.ntt.co.jp) wrote:
> On 2017/02/17 22:32, Stephen Frost wrote:
> > * Amit Langote (Langote_Amit_f8@lab.ntt.co.jp) wrote:
> >> In certain cases, pg_dump's dumpTableSchema() emits a separate ALTER T=
ABLE
> >> command for those schema elements of a table that could not be included
> >> directly in the CREATE TABLE command for the table.
> >=20
> > Any chance we could start adding regression tests for how pg_dump
> > handles partitions?  I'm just about to the point where I have pretty
> > much everything else covered (at least in pg_dump.c, where it's not a
> > hard-to-reproduce error/exit case, or something version-dependent).
> >=20
> > If you have any questions about how the TAP tests for pg_dump work, or
> > about how to generate code-coverage checks to make sure you're at least
> > hitting every line (tho, of course, not every possible path), let me
> > know.  I'd be happy to explain them.
>=20
> Yeah, I guess it would be a good idea to have some pg_dump TAP test
> coverage for the new partitioning stuff.  I will look into that and get
> back to you if I don't grok something there.

As you may have seen, I've added some tests to the pg_dump TAP tests for
partitioning to cover lines of code not already covered.  There are
still some bits not covered though, which you can see here:

https://coverage.postgresql.org/src/bin/pg_dump/pg_dump.c.gcov.html

If you have any questions about the way the pg_dump tests work, feel
free to ask.

Thanks!

Stephen

--7155Inxk/SN6GkBE
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: Digital signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAEBCgAGBQJY0AYaAAoJEO1sijiDR2RVZHwP/3nHumy4cNw4mOf1QLG+04Hc
emu3yARp10r69PK0A3HOyIbrqen5pskqoYz6ozAvtL+EFZicg7os8bD68rCa+BW9
MDJ7IhkgOJwnyzRkFWtYg7HyFhhM6X7qGKEXujRNzsJjxoNnLLmR1j12qjiYGPT4
BGkjg/s9h8dKHsVoEO6XUt+bi7m0FeAZa0jEwFYZzeQo6BLCAn6oGBrUIKHyZaQ6
9TPDwPd3pNlP+A1zGbahOsvT6eRGkvyn9jvwQ5V+9s0TXpZK6mGrxwuyT4g/pOKk
LkvPtXpe2rYFPrTs2vjMrctwJ/heHO9lD8LGjVO5jJ/RqcV5ynjjV10A9kf43rWY
udCAmxKlWDUGedYKk2B5KUyPbNqF4IRpguS5EkWOAY00Y8qdnNHlhg00hf8ctWVn
gq1XG1LY/VJB+4s0SHQAjk8zB8g6RUqKqmGbmqa5YGoRVYnsTd1QHvTKfi9r39XQ
/2XYJWTwiMgGs+7dhZaV9vPSaqx0VbDw1UO7vnmJ9xaUB2T9504aZSr6Hh4WSWxO
6D8jBTUiy0yWpgRdFRjr+15JRgNUxlQfWcEWnH7btJNl+QEa2GJ5+LIqmaR4QIfY
AuLlJK+YAyuY00fOb9ms2yNKFz2GyunVeDj0Sjg87EM7x1Bo8tBwzUCjirnOqmvp
jcrsJJSVCEtTOItg6aQg
=nXix
-----END PGP SIGNATURE-----

--7155Inxk/SN6GkBE--