Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1csCUo-0005yE-DR for pgsql-hackers@arkaria.postgresql.org; Sun, 26 Mar 2017 18:02:30 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1csCUn-0002N2-N6 for pgsql-hackers@arkaria.postgresql.org; Sun, 26 Mar 2017 18:02:29 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1csCUl-0002M3-7t for pgsql-hackers@postgresql.org; Sun, 26 Mar 2017 18:02:27 +0000 Received: from mail-vk0-x22d.google.com ([2607:f8b0:400c:c05::22d]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1csCUd-0004pg-Gp for pgsql-hackers@postgresql.org; Sun, 26 Mar 2017 18:02:26 +0000 Received: by mail-vk0-x22d.google.com with SMTP id r69so30926857vke.2 for ; Sun, 26 Mar 2017 11:02:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=2ndquadrant-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:mime-version:content-disposition :content-transfer-encoding:in-reply-to:user-agent; bh=FbEE20SSHzaoxIfkIvmd4oh++KnM21weraNh7+MyQ40=; b=o3VmYOy+FGEhKWUusfVoV3w+N6i+IfQn6iN4+Ok7/UT/dONYMzgphivSyshPuRVJTA bTb89XUnniXnvQDM+UGuMo+NQYzKoiMqFGCGjWE5YGYy8s5H6qZDB2FDB9tlZj3sPqOi J0isHwG0DFWzIs9SBqZY2LMnQ3Frd5OCSuZDkapi/ONUJmhqF7zTR3jfWVhTTgVtDaPI Je3G7CC5EqHvaqEH/DETd8QLvdzSwQwgnyRZO9sW3kzvlD7DQJBBKvv4YfKkWyPSdKWy ouOghWTXenz96bGANFh9EWrahrB1O5GZs0w+tFKZTn411Su9fzxFv5/gs5VmwMmupCv4 1RVg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=FbEE20SSHzaoxIfkIvmd4oh++KnM21weraNh7+MyQ40=; b=k3OmDB6AnNFER7kOBJjQ1MKHlEZ2WXgdjlTwDMQ7pGNeHxxQ4VeNpCHyPCIxGwJnd6 eD30sYVWDlgKVOgopLYiM6o3vzIkcIyUVwZRShupy8W+TaJQEZno3GkxNTR/JkBDPttY OvK9wym+gtZIV4qNsdtzDwbja5MTnsAC5A+758MGGHO62UxYUWZv+s5xh+cmJ7Kw+Xnp Yg1tb9IgB0yN4Pwiam8jT/X4qrYMjuxtbP+JF80KaYmkQeGfT964m/RssixkW6VO5idc 1aExliSQeJM2+Mn4L++24kGwDhR40uR3zbk8u0Z7i994A2tViUPH70ssn+4/0jI5+ASe mgxA== X-Gm-Message-State: AFeK/H3OIJaA2xeCDPEwX/0rUpAoXaYxVpxvyHZmCL18btDH0+JxXbaJngr+qk/JKeFCOOw8 X-Received: by 10.31.180.200 with SMTP id d191mr8302560vkf.54.1490551337156; Sun, 26 Mar 2017 11:02:17 -0700 (PDT) Received: from alvin.alvh.no-ip.org ([186.37.202.238]) by smtp.gmail.com with ESMTPSA id w135sm2491848vkw.0.2017.03.26.11.02.16 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 26 Mar 2017 11:02:16 -0700 (PDT) Received: by alvin.alvh.no-ip.org (Postfix, from userid 1000) id 5DA57CD0; Sun, 26 Mar 2017 15:02:12 -0300 (CLST) Date: Sun, 26 Mar 2017 15:02:12 -0300 From: Alvaro Herrera To: Nikolay Shaplov Cc: pgsql-hackers@postgresql.org Subject: Re: [PATCH] Move all am-related reloption code into src/backend/access/[am-name] and get rid of relopt_kind for custom AM Message-ID: <20170326180212.6kdmzc6i2icsax6s@alvherre.pgsql> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1556865.P0kqmzk0Jg@x200m> User-Agent: NeoMutt/20170206-195-7adf12 (1.7.2) X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgsql-hackers Precedence: bulk Sender: pgsql-hackers-owner@postgresql.org Nikolay Shaplov wrote: > If I would think about it now: we always know how many options we will have. > So we can just pass this number to palloc and assert if somebody adds more > options then expected... What do yo think about it. I think we need to preserve the ability to add custom options, because extensions may want to do that. -- Álvaro Herrera https://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers