Date: Thu, 30 Mar 2017 22:27:06 +0300
From: Aleksander Alekseev <a.alekseev@postgrespro.ru>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Teodor Sigaev <teodor@sigaev.ru>,
	"pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>,
	Anastasia Lubennikova <lubennikovaav@gmail.com>,
	Peter Geoghegan <pg@heroku.com>, David Steele <david@pgmasters.net>,
	Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Subject: Re: WIP: Covering + unique indexes.
Message-ID: <20170330192706.GA2565@e733.localdomain>
References: <56168952.4010101@postgrespro.ru>
 <46e1f13e-6887-3851-a525-f046029341eb@postgrespro.ru>
 <20170324124709.22419.51178.pgcf@coridan.postgresql.org>
 <c1f7c059-597f-44e8-7308-73d76ffd493c@sigaev.ru>
 <CA+TgmoY0CU4s0w_8ZSBNJEqQ15jcFj5Lsx062s-518PjwAP85Q@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="UugvWAfsgieZRqgk"
Content-Disposition: inline
In-Reply-To: 
 <CA+TgmoY0CU4s0w_8ZSBNJEqQ15jcFj5Lsx062s-518PjwAP85Q@mail.gmail.com>
User-Agent: Mutt/1.8.0 (2017-02-23)
Precedence: bulk
Sender: pgsql-hackers-owner@postgresql.org


--UugvWAfsgieZRqgk
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi Robert,

> Has anybody done some testing of this patch with the WAL consistency
> checker?  Like, create some tables with indexes that have INCLUDE
> columns, set up a standby, enable consistency checking, pound the
> master, and see if the standby bails?

I've decided to run such a test. It looks like there is a bug indeed.

Steps to reproduce:

0. Apply a patch.
1. Build PostgreSQL using quick-build.sh [1]
2. Install master and replica using install.sh [2]
3. Download test.sql [3]
4. Run: `cat test.sql | psql`
5. In replica's logfile:

```
FATAL:  inconsistent page found, rel 1663/16384/16396, forknum 0, blkno 1
```

> Has anybody tested this patch with amcheck?  Does it break amcheck?

Amcheck doesn't complain.

[1] https://github.com/afiskon/pgscripts/blob/master/quick-build.sh
[2] https://github.com/afiskon/pgscripts/blob/master/install.sh
[3] http://afiskon.ru/s/88/93c544e6cf_test.sql

--=20
Best regards,
Aleksander Alekseev

--UugvWAfsgieZRqgk
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEECAokn0QZCoIHW4GpEEnCBLXCDtYFAljdXAQACgkQEEnCBLXC
DtaY8BAAkJTTfTLqWIsuAk7IMCe8ocu58ItjNn0JL5lUG05MRKbzmPAW+Co7Amxn
R2TbK0KWaZOG8xpUOiGyCw8gjzUGBOAuvbNrYoIIJSSLm6ybWkfyLFHEeMEskAyx
fEeMhCrGUbDSzDDEfT6rgbIYM6s4SzwWHnj6kUIan9T2UwLiLOWqA+ybB5QITdAD
mIiVrjoLwin31Ndjw2vwPlFoI4kgI9sk6Xh2AOZLwpGgx8l3lXNQCj+y2wkKoqiD
yE7tlG+AmBZQnI8zWdBEMPQf7fIDJI6lMnk26riA6AuX3cNaIBbDCrYrrklXcS/J
Ye1mMo4Zo+cY3zaZ4yBPQJ1csFnHa9NZ+4vMXK1CKBL8hRcUM1lk1EGUk17VWmU4
WqF23wVAmxGANWdHv4ib9TnJKtDGR7tfnLvvdawQOrlzEtjQxQfhlheybviU7TV0
q7smQj9vtmWFsFDtenMHH2GPyAapWG7iR5w95H2j8njM1RG/TYHKH+QS9fUIioCm
IENT1TLz3vjMObLHieivdt6RCvN2/9UTMRGLK/EIh3FhalnKcoIEwZfLoMe5IKpL
VJ0hd3VMXY1Iq0R9eyWoy5LSGJVLhTHC7sJQdoKsSUpvj5adMttPIPP+m7CIBzoN
Dfjbs+2KxCm/bnzwsxHbMVst2uYCUemg2u0Mj6VwM1Kvy2equQk=
=w6Wd
-----END PGP SIGNATURE-----

--UugvWAfsgieZRqgk--