Date: Mon, 3 Apr 2017 16:26:13 -0700
From: Andres Freund <andres@anarazel.de>
To: Vaishnavi Prabakaran <vaishnaviprabakaran@gmail.com>
Cc: David Steele <david@pgmasters.net>,
	Craig Ringer <craig@2ndquadrant.com>,
	Daniel Verite <daniel@manitou-mail.org>,
	Michael Paquier <michael.paquier@gmail.com>,
	"Prabakaran, Vaishnavi" <VaishnaviP@fast.au.fujitsu.com>,
	Haribabu Kommi <kommi.haribabu@gmail.com>,
	"Tsunakawa, Takayuki" <tsunakawa.takay@jp.fujitsu.com>,
	Dmitry Igrishin <dmitigr@gmail.com>,
	PostgreSQL Hackers <pgsql-hackers@postgresql.org>,
	Manuel Kniep <m.kniep@web.de>,
	"fujita.etsuro@lab.ntt.co.jp" <fujita.etsuro@lab.ntt.co.jp>,
	"Iwata, Aya" <iwata.aya@jp.fujitsu.com>
Subject: Re: PATCH: Batch/pipelining support for libpq
Message-ID: <20170403232613.dcd4rzbhad2nkh2p@alap3.anarazel.de>
References: <3200d6d3-a82a-4778-b021-475b3adbe4dc@manitou-mail.org>
 <41685247-0a06-1fbb-d731-1b2b6bd8df8e@pgmasters.net>
 <CAOoUkxS31gTRwYr9N01YidUUoAwy0jU+3VbgGCtuBJHRTpMmFg@mail.gmail.com>
 <20170403210501.6nbmlkg6g3ch7lew@alap3.anarazel.de>
 <CAOoUkxQB+TvNJTJqUq7E32WQL240V+PmYL1Ebma0c5PdSJ+qkg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: 
 <CAOoUkxQB+TvNJTJqUq7E32WQL240V+PmYL1Ebma0c5PdSJ+qkg@mail.gmail.com>
Precedence: bulk
Sender: pgsql-hackers-owner@postgresql.org

On 2017-04-04 09:24:23 +1000, Vaishnavi Prabakaran wrote:
> Hi,
> On Tue, Apr 4, 2017 at 7:05 AM, Andres Freund <andres@anarazel.de> wrote:
> 
> > On 2017-04-03 14:10:47 +1000, Vaishnavi Prabakaran wrote:
> > > > The CF has been extended until April 7 but time is still growing short.
> > > > Please respond with a new patch by 2017-04-04 00:00 AoE (UTC-12) or
> > this
> > > > submission will be marked "Returned with Feedback".
> > > >
> > > >
> > > Thanks for the information, attached the latest patch resolving one
> > > compilation warning. And, please discard the test patch as it will be
> > > re-implemented later separately.
> >
> > Hm.  If the tests aren't ready yet, it seems we'll have to move this to
> > the next CF.
> >
> >
> Thanks for your review and I will address your review comments and send the
> newer version of patch shortly.

Cool.

> Just quickly, Is it not ok to consider only the code patch for this CF
> without test patch?

I'd say no, it's not acceptable.  This is too much new code for it not
to be tested.

Andres


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers