Date: Tue, 4 Apr 2017 11:42:57 -0400
From: Stephen Frost <sfrost@snowman.net>
To: David Steele <david@pgmasters.net>
Cc: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>,
	Fujii Masao <masao.fujii@gmail.com>,
	"Tsunakawa, Takayuki" <tsunakawa.takay@jp.fujitsu.com>,
	Michael Paquier <michael.paquier@gmail.com>,
	Pg Hackers <pgsql-hackers@postgresql.org>
Subject: Re: PATCH: Make pg_stop_backup() archive wait optional
Message-ID: <20170404154257.GL9812@tamriel.snowman.net>
References: <0A3221C70F24FB45833433255569204D1F6B5134@G01JPEXMBYT05>
 <49d70e8e-33bf-2390-e717-ba9562621aa4@pgmasters.net>
 <0A3221C70F24FB45833433255569204D1F6B607B@G01JPEXMBYT05>
 <CAHGQGwHRmE+db96=9FDPLVxWRN0gSf6kU7nM6-WnEKot2OanOg@mail.gmail.com>
 <ee92e800-f983-c3a7-ddae-92acae162832@pgmasters.net>
 <20170322153703.GK9812@tamriel.snowman.net>
 <CAHGQGwFd+7D5UPwLLCW3=5mmDzXOKN56gySRUqdRzaeVK_L2HQ@mail.gmail.com>
 <20170322191451.GY9812@tamriel.snowman.net>
 <4f41afe5-0947-ce53-e985-971bc774169b@2ndquadrant.com>
 <22d564fc-545f-d242-fef1-b33dac9ac1f6@pgmasters.net>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="8h6gf4xN8Ileao4k"
Content-Disposition: inline
In-Reply-To: <22d564fc-545f-d242-fef1-b33dac9ac1f6@pgmasters.net>
User-Agent: Mutt/1.5.21 (2010-09-15)
Precedence: bulk
Sender: pgsql-hackers-owner@postgresql.org


--8h6gf4xN8Ileao4k
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

* David Steele (david@pgmasters.net) wrote:
> On 3/22/17 4:42 PM, Peter Eisentraut wrote:
> >On 3/22/17 15:14, Stephen Frost wrote:
> >>>-SELECT * FROM pg_stop_backup(false);
> >>>+SELECT * FROM pg_stop_backup(false [, true ]);
> >>>
> >>>I think that it's better to get rid of "[" and "]" from the above beca=
use
> >>>IMO this should be the command example that users actually can run.
> >>Using the '[' and ']' are how all of the optional arguments are
> >>specified in the documentation, see things like current_setting() in our
> >>existing documentation:
> >
> >In the synopsis, but not in concrete examples.
>=20
> Wasn't quite sure what the protocol was in this case, and figured it
> was easier to subtract than to add.

Forgot to close this out sooner, apologies.

This has been committed now.

Thanks!

Stephen

--8h6gf4xN8Ileao4k
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: Digital signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAEBCgAGBQJY478BAAoJEO1sijiDR2RVNnwP/AxjuHi6x+KLvmSgi3YkCSyx
2Y6oC5SuXy4YwW6H3CQ8gfYOgd7iL3ioBhDlmxiPz3IswgNXK2ILsggu8M1RWPQK
ndxjFV8pLWYJddlVnhyWDIut8AcmO/hnEC+/EIvY9MjOIS5Syl7SF7VM7IDD9XBg
Knlv2+qSCGV2+ToXGwQYDYeKiyG39fbqDgZ2e7zLVQXcnsGGRvl0wIg8JdA6hnPo
xfuKEHsYVEtXPWIrM3ZemrKwnW1SVdNeZO81YEZ/p3+BLhtd/82PAhjY4Xo+ypZb
F2zqdNJR9GWknVknvyecsj8Dcz99nOE7HAdEYePGnkW/jnu/RlKO+RWppCrsyr/t
SuZrfpW3HI5r9uKeEJVH3D49xbC1TAE2btSJCL7Jgd3qtNs1OjmV/xKf1/hx5b2m
YA28127kdcy7jU5TM2IgXgp3n8ZQYWW5VH1dtMNuMtsk7Lk0GNxn4mYSfmch+rhH
jw6GdTi6xzFtTd0VqFza/ntpY7vbA7v+wLCDzkfUqVQASrg1IBnUYAS2NSHAPPWG
m0DM67hZeWuH5OaDGCPu42hESm5+i6fQ2a5EA5/ryJq5QJnth6AVIyRhGaayQQ3I
qZ7Z2Xm+b85455zlZqjMFyh/ZHImjdwUAGebSgNscaLpqviWZ7gCPXEh2Bpb9Imn
znSZRqaMMfV8+SvC2IUD
=U0JQ
-----END PGP SIGNATURE-----

--8h6gf4xN8Ileao4k--