Date: Wed, 5 Apr 2017 11:07:02 -0400
From: Stephen Frost <sfrost@snowman.net>
To: Andres Freund <andres@anarazel.de>
Cc: Tom Lane <tgl@sss.pgh.pa.us>,
	Michael Paquier <michael.paquier@gmail.com>,
	Peter Eisentraut <peter.eisentraut@2ndquadrant.com>,
	PostgreSQL mailing lists <pgsql-hackers@postgresql.org>,
	Noah Misch <noah@leadboat.com>
Subject: Re: Rewriting the test of pg_upgrade as a TAP test
Message-ID: <20170405150702.GE9812@tamriel.snowman.net>
References: <62a4e16e-5ea3-89c9-c94a-ee3be953b94a@2ndquadrant.com>
 <20170403153200.jqntjo7zat6x5rhh@alap3.anarazel.de>
 <42d412a2-9cd7-7ee1-0c1a-e8d230d568b0@2ndquadrant.com>
 <CAB7nPqR9JWCoU8z_CXovL2UkTxahcEx3TzyBYzk3qyXh+MTXMg@mail.gmail.com>
 <20170405135211.GZ9812@tamriel.snowman.net>
 <6679.1491401713@sss.pgh.pa.us>
 <20170405144041.GC9812@tamriel.snowman.net>
 <20170405144521.7guijbgfxpstfbq2@alap3.anarazel.de>
 <20170405145019.GD9812@tamriel.snowman.net>
 <20170405150134.ruqy7xqeq5uuew5y@alap3.anarazel.de>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="UKuy+k5wfKIxkQYk"
Content-Disposition: inline
In-Reply-To: <20170405150134.ruqy7xqeq5uuew5y@alap3.anarazel.de>
User-Agent: Mutt/1.5.21 (2010-09-15)
Precedence: bulk
Sender: pgsql-hackers-owner@postgresql.org


--UKuy+k5wfKIxkQYk
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Andres,

* Andres Freund (andres@anarazel.de) wrote:
> On 2017-04-05 10:50:19 -0400, Stephen Frost wrote:
> > Probably because the point was brought up that the regression tests for
> > pg_upgrade spend a bunch of time doing something which, ultimately,
> > don't actually add any real value.  Yes, there are bits of the core
> > regression tests that currently add value over what we have through
> > other approaches, but that's not where the bulk of running those tests
> > go.
>=20
> Create a separate patch [& thread] about that, don't conflate the
> topics.  I'm very much in favor of this rewrite, I'm very much not in
> favor of only using some targeted testsuite.  By combining two
> independent changes, you're just making it less likely that anything
> happens.

I've made it clear, I thought, a couple of times that I agree with the
rewrite and that we should move forward with it.  Nothing on this
sub-thread changes that.  It's also registered in the 2017-07
commitfest, so I wouldn't think that there's a risk of it being
forgotten or that we need to cut off all discussion about what may
change between now and July that would be relevant to this patch.

> > We don't look at the gin index after the upgrade in the current
> > pg_upgrade testing, so I don't see why you feel it's at all valuable.
>=20
> It's be trivial to add a VACUUM to the point where analyze_new_cluster
> is currently run.  And I've previously run more manual tests.  Is that
> perfect - no, definitely not.

Being trivial doesn't mean it's something we're actually doing today.

Given that we aren't actually changing anything in the index during a
same-version pg_upgrade, nor are we changing the code that's run by
that VACUUM, I'm curious just what we're ending up testing that's
different from just restarting the existing cluster and running a new
VACUUM.

Thanks!

Stephen

--UKuy+k5wfKIxkQYk
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: Digital signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAEBCgAGBQJY5QgWAAoJEO1sijiDR2RVeUwP/2Gab65wQi72RkrVyD2RhrgD
apWnB5FJ7WZvhzHPgeJ5JwHFnKK3pMIr/Uht8RId7l0y5uUFtnTVDKy03CpeH+93
eGVZMhVkzBtzOMVJkWxfT5nizqAA4E8hmfqjdMns8ZrAtXWJC051qpGvmXV5gfWu
NrqjM/9o07F+bhHND+IjuRTCe/CWrWtcPhoX5t0GzoKEcV1BSlkHxvfbFwnxjTXC
XrrfE8rZtyi+xXmkiPS0pU82GINN4MGfXtu1vtoDc8zhnLAw55rOIT0mMjOrmi1z
5ZYYmxnZmvfyfjvQZw3yk0hVNjEWRr0XYeCk8Fy+8PMyvCyFrPkscXEpp2Npr0Po
SERdGTmfXKaNOFqy5PqvE8q4Q9zaklROXXs9O6M19tQqDWcXoQIBLrd1BOktOzBD
l+l+LjzVo0HBIF96pg9zxg2ivnv5Uty6K+YWWGnWd+Dhw+2bzLsrCNvxKFTaRApu
KM8bd7DhZJguu0YrjI2bIfCJ1CNQReQQt0/zD4Jflhu/8H9CQJfLBuhIvaye2Lfy
KiFu7S6pGxTmSpEw27rAGqY+ZWA3WHwPEwY9OZNAUC8LrFbRYGg7HM39IzPFJQ9X
ME1LooE67l8wVJZBj2/jcfyDq8bI+sKEqxqAyEaCSyHE8tVu9/h2RVFEBzurXDjQ
1P9BAKgZPXyh2B2Zd93a
=enqr
-----END PGP SIGNATURE-----

--UKuy+k5wfKIxkQYk--